Review main Merged Breaking

81186[!!!][TASK] Remove security.usePasswordPolicyForFrontendUsers

Torben Hansen CR +2 V +2 Normal +71 −158 updated 09/27/23, 19:13

Commit message

The feature toggle `security.usePasswordPolicyForFrontendUsers` has
been introduced in TYPO3 12.3 to provide a smooth migration path for
websites using the deprecated TypoScript based password validation
in the password recovery process of ext:felogin.

Since the TypoScript based password validation in ext:felogin has been
removed with #101097, the previously introduced feature toggle has
become obsolete.

This change removes the feature toggle
`security.usePasswordPolicyForFrontendUsers` and all related code.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 3

Files 13

Review log 1114

  1. Torben Hansen uploaded patch set 1 09/24/23, 12:32

  2. core-ci voted on patch set 1 V +1 09/24/23, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47120

  3. Oliver Klee voted on patch set 1 CR +1 09/24/23, 12:40

  4. Benni Mack commented on patch set 1 09/24/23, 16:26

    Please also add the feature to "Features.php" to have it always enabled now
  5. Benni Mack commented on patch set 1 09/24/23, 16:27

    In addition, we can remove the property via the Silent Upgrade Wizard.
  6. Torben Hansen uploaded patch set 2 CR +1 V +1 09/26/23, 17:10

  7. Torben Hansen commented on patch set 1 09/26/23, 17:11

    Reply

    Yes, done.

    Reply

    Done
  8. Torben Hansen uploaded patch set 3 09/26/23, 17:14

  9. core-ci voted on patch set 2 V +1 09/26/23, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47196

  10. core-ci voted on patch set 3 V +1 09/26/23, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47197

  11. Benni Mack voted on patch set 3 CR +1 09/27/23, 15:42

  12. Oliver Klee voted on patch set 3 CR +1 09/27/23, 16:06

  13. Georg Ringer voted on patch set 3 V +2 CR +2 09/27/23, 19:13

  14. Georg Ringer merged patch set 4 09/27/23, 19:13