Review main Merged

81189[TASK] Add tests to GraphicalFunctions getImageScale

Benni Mack CR +2 V +2 Hard +299 −72 updated 09/25/23, 10:36

Commit message

This change adds more examples to getImageScale
to have a good test bed in place before we move
code around for v13.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 09/24/23, 16:21

  2. Benni Mack uploaded patch set 2 09/24/23, 16:22

  3. core-ci voted on patch set 1 V -1 09/24/23, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47124

  4. core-ci voted on patch set 2 V +1 09/24/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47126

  5. Oliver Klee voted on patch set 2 V +1 09/24/23, 17:21

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/25/23, 10:28

  7. Benjamin Franzke merged patch set 3 09/25/23, 10:36