Review 12.4 Merged

81213[BUGFIX] Show but preserve invalid classes in link-browser

Benjamin Franzke CR +2 V +2 Normal +57 −23 updated 09/26/23, 08:20

Commit message

In case a link with an invalid CSS class is edited,
the class value is not simply invalidated and shown
as empty (which isn't true), but a virtual select option
"[ INVALID VALUE (…) ]" is added (and selected) that
documents the fact that the current value invalid,
but will be preserved upon updates. (as in FormEngine)

This allows the editor to choose between preserving,
removing or changing to another css class value.

With this change applied, we can not properly
remove empty value. Note that empty values previously
implicitly preserved existing values, which made
it impossible to remove a link title or target.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5