Review 12.4 Merged

81217[TASK] Update stale icons.js build

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 09/25/23, 13:50

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 09/25/23, 13:42

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 09/25/23, 13:43

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/25/23, 13:43

  4. core-ci voted on patch set 1 V +1 09/25/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47158

  5. Benjamin Franzke commented on patch set 1 09/25/23, 13:49

    Explanation: G(err)it automatically merged the following changes from https://review.typo3.org/c/Packages/TYPO3.CMS/+/81125/2/typo3/sysext/backend/Resources/Public/JavaScript/icons.js when https://review.typo3.org/c/Packages/TYPO3.CMS/+/81096 was merged, but didn't take into account that terser would change some identifiers based on previous content.
  6. Benjamin Franzke merged patch set 2 09/25/23, 13:50