81220[BUGFIX] Allow to save date without time in Extbase
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1220
-
TYPO3com uploaded patch set 1 09/25/23, 17:05
-
core-ci voted on patch set 1 V -1 09/25/23, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47164
-
Benni Mack updated the commit message in patch set 2
V -109/26/23, 08:17 -
core-ci voted on patch set 2 V -1 09/26/23, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47171
-
Benni Mack commented on patch set 3
V -106/27/24, 17:50Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 06/27/24, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60482
-
Stefan Bürk commented on patch set 3 CR -1 06/29/24, 01:04
DateTimeConverter.php:131Modified $dateFormat should be stripped to remove empty spaces from start/end, otherwise this may not match as expected: ``` $dateFormat: "Y-m-d H:i:s" => "Y-m-d " $value: "2019-12-25" ``` On top of that, PHP will parse that but use the "actual current" time information and set it as time information. That means, executed on `2024-05-12 23:45:12` that would lead with the example values above to a timestamp matchon "2019-12-25 23:45:12" - which I'd postulate is not what would be expected. To mitigate this, on successfull retrieving the instance the value must be set. On top of that, we should cover this with tests for all possible $targetType`s. -
Stefan Bürk uploaded patch set 4
CR -1V -106/29/24, 01:14 -
Stefan Bürk commented on patch set 4 06/29/24, 01:14
DateTimeConverter.php:131ReplyDone -
Stefan Bürk updated the commit message in patch set 5 06/29/24, 01:15
-
core-ci voted on patch set 4 V -1 06/29/24, 01:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60615
-
core-ci voted on patch set 5 V -1 06/29/24, 01:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60616
-
Stefan Bürk uploaded patch set 6
V -106/29/24, 20:00 -
core-ci voted on patch set 6 V +1 06/29/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60633
-
Stefan Bürk commented on patch set 6 06/29/24, 20:08
Unresolved
I'm not sure if we really should make that change. This makes the converter kind of qussiong now. Literally, if passing the correct format (DateFormat) for the incoming value the value gets convertet - there are unit test for it demonstrating it. Reading the issue, I'd say that the issue originates more from a extbase model usage and kind of route handling on persisting, having a form field where only the date is entered - but the extbase magic is assumging the full datetime format. I'm not so much in the extbase area, but I guess the issue creater should configire his action/add custom initialze method to convert the datetime in that case with the correcet date format (`Y-m-d`) to match the incomming value. This change breaks now the "convert for given format" by adding automatic stripping and guessing to it. I made the changes to get it working, but I'm feeling kind of "naah we should not do that". -
Benni Mack updated the commit message in patch set 7
V +110/18/24, 13:36 -
core-ci voted on patch set 7 V -1 10/18/24, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68002
-
Benni Mack marked it work in progress 03/25/25, 19:57
-
Benni Mack commented on patch set 7 03/25/25, 19:57
I consider to abandon this one... why? Did not get any feedback (made via PR), and no interest in this one. -
Benni Mack abandoned the change 03/25/25, 19:58
will abandon, I don't like "attempts to convert" I want clarity.