81232[BUGFIX] Avoid PHP deprecation notice in menu_related_pages CE
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
-
Verified V +2 Done
- Andreas Kienast +2
- core-ci +1 CI
Issues 1
Files 1
Review log 1015
-
Ramón Schlosser uploaded patch set 1 09/25/23, 10:42
-
Ramón Schlosser updated the commit message in patch set 2 09/25/23, 10:51
-
core-ci voted on patch set 1 V -1 09/25/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47145
-
core-ci voted on patch set 2 V -1 09/25/23, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47146
-
Ramón Schlosser updated the commit message in patch set 3
V -109/25/23, 11:25 -
core-ci voted on patch set 3 V -1 09/25/23, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47148
-
Oliver Klee commented on patch set 3 09/25/23, 11:45
Thanks for fixing this! As this is not mentioned in the ticket: Is the main branch not affected? (If it is affected, it should be part of the Releases line, and the change should go to main first, not to 12.4. Changes usually are expected to go to the highest affect branch first, and the person who merges the change then is responsible for backporting the change to the corresponding lower branches.) And if 11.5 is affected as well, it should be part of the Releases line, too. -
Ramón Schlosser commented on patch set 3 09/25/23, 12:01
Reply
Hi Oliver, thanks for you input. Since this is my first time contributing in the TYPO3 Core I'm still trying to find my way. I'll update the patchset with your suggested input now. -
Andreas Kienast uploaded patch set 4
V -109/25/23, 13:20 -
Andreas Kienast commented on patch set 4 09/25/23, 13:35
Build will fail again, something is off with the 12.4 branch... -
core-ci voted on patch set 4 V -1 09/25/23, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47155
-
Andreas Kienast rebased onto patch set 5
V -109/25/23, 13:51 -
Andreas Kienast voted on patch set 5 V +2 CR +2 09/25/23, 14:01
-
core-ci voted on patch set 5 V +1 09/25/23, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47159
-
Andreas Kienast merged patch set 6 09/25/23, 14:02