Review main Merged

81234[BUGFIX] Avoid PHP deprecation notice in menu_related_pages CE

Ramón Schlosser CR +2 V +2 Easy +1 −1 updated 09/25/23, 14:02

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Ramón Schlosser uploaded patch set 1 09/25/23, 12:23

  2. core-ci voted on patch set 1 V +1 09/25/23, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47150

  3. Oliver Klee updated the commit message in patch set 2 V +1 09/25/23, 12:49

  4. Oliver Klee updated the commit message in patch set 3 09/25/23, 12:49

  5. Oliver Klee commented on patch set 3 V +1 CR +1 09/25/23, 12:50

    Thank you for contributing this fix! <3 (I have edited the commit message so the subject line is short enough to fit in one line, and so that the target releases are ordered from highest to lowest.)
  6. Ramón Schlosser commented on patch set 3 09/25/23, 12:53

    Reply

    Perfect. Thanks a lot! I assume we can abandon https://review.typo3.org/c/Packages/TYPO3.CMS/+/81232 now? I didn't how to simply change the target branch so I submitted a new one. Hope this was okay.
  7. core-ci voted on patch set 2 V +1 09/25/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47152

  8. core-ci voted on patch set 3 V +1 09/25/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47153

  9. Andreas Kienast commented on patch set 3 V +2 CR +2 09/25/23, 13:11

    Thank you for your first contribution!
  10. Oliver Klee commented on patch set 3 09/25/23, 13:16

    > I assume we can abandon https://review.typo3.org/c/Packages/TYPO3.CMS/+/81232 now? Yes, exactly. Could you please try to abandon the 12.4 change? (I don't have the permissions to do so.)
  11. Andreas Kienast commented on patch set 3 09/25/23, 13:48

    Reply

    Please no! Backport is already in place!
  12. Andreas Kienast merged patch set 4 09/25/23, 14:02