81253[BUGFIX] Toggle preview state in Form Editor
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1315
-
Andreas Kienast uploaded patch set 1 09/26/23, 11:02
-
core-ci voted on patch set 1 V +1 09/26/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47182
-
Stefan Bürk commented on patch set 1 V +1 09/26/23, 12:54
+1 verified for now. JS code looks good for me, but please JS experts first. Tested it, could not reproduce it with the patch anymore. No console errors and could not break it in anyway. Clicked around in the backend, could not find side effect either on a short click around. -
Benjamin Franzke voted on patch set 1 V +1 CR +1 09/27/23, 10:00
-
Andreas Kienast commented on patch set 1 CR -1 09/27/23, 10:03
found more cases -.- -
Andreas Kienast uploaded patch set 2
CR +1V +109/27/23, 10:07 -
Andreas Kienast uploaded patch set 3 09/27/23, 10:09
-
Andreas Kienast uploaded patch set 4 09/27/23, 10:11
-
Andreas Kienast updated the commit message in patch set 5 09/27/23, 10:12
-
core-ci voted on patch set 5 V +1 09/27/23, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47228
-
Benjamin Franzke voted on patch set 5 CR +1 09/27/23, 10:26
-
Benjamin Franzke voted on patch set 5 V +1 09/27/23, 10:28
-
Stefan Bürk voted on patch set 5 V +1 CR +1 09/27/23, 12:56
-
Andreas Kienast voted on patch set 5 V +2 CR +2 09/27/23, 13:05
-
Andreas Kienast merged patch set 6 09/27/23, 13:05