81255[BUGFIX] Make combine operation compatible with ImageMagick 7
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 3446
Show 1421 earlier messages
-
Friedemann Altrock uploaded patch set 1 09/26/23, 15:08
-
Friedemann Altrock updated the commit message in patch set 2 09/26/23, 15:09
-
Friedemann Altrock updated the commit message in patch set 3 09/26/23, 15:10
-
Friedemann Altrock commented on patch set 3 09/26/23, 15:11
WIP while I read up on how we document breaking changes. -
core-ci voted on patch set 1 V +1 09/26/23, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47187
-
core-ci voted on patch set 2 V +1 09/26/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47188
-
core-ci voted on patch set 3 V +1 09/26/23, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47189
-
Friedemann Altrock uploaded patch set 4
V +109/26/23, 16:16 -
core-ci voted on patch set 4 V +1 09/26/23, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47193
-
Simon Schaufelberger commented on patch set 4 09/26/23, 17:29
Breaking-91274-ImageCompositeOperationsFailWithImageMagick7.rst:362 spaces -
Friedemann Altrock uploaded patch set 5
V +109/27/23, 08:55 -
Friedemann Altrock commented on patch set 5 09/27/23, 08:56
Breaking-91274-ImageCompositeOperationsFailWithImageMagick7.rst:36ReplyDone -
core-ci voted on patch set 5 V +1 09/27/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47218
-
Friedemann Altrock commented on patch set 5 10/06/23, 08:16
MethodCallStaticMatcher.php:1604should be 3, function takes a third (optional) parameter. -
Friedemann Altrock uploaded patch set 6
V +110/06/23, 08:26 -
Friedemann Altrock commented on patch set 6 10/06/23, 08:26
MethodCallStaticMatcher.php:1604ReplyDone -
core-ci voted on patch set 6 V +1 10/06/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47458
-
Simon Schaufelberger uploaded patch set 7
V +101/25/24, 14:22 -
core-ci voted on patch set 7 V +1 01/25/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52184
-
Benni Mack commented on patch set 7 01/25/24, 14:31
GraphicalFunctions.php:634this needs to be escaped. -
Benni Mack commented on patch set 7 01/25/24, 14:35
GraphicalFunctions.php:634does this also work with IM6 and GM?
-
Friedemann Altrock commented on patch set 7 01/25/24, 14:49
GraphicalFunctions.php:634ReplyI don't understand why? +matte and -quality are also not escaped.GraphicalFunctions.php:634ReplyYes. The current DDEV container on main has ImageMagick in version 6.9.11-60 and GraphicsMagick in version 1.4 snapshot-20210721. Both work for the image processing test in the Environment module. -
Friedemann Altrock uploaded patch set 8
V +108/02/24, 14:20 -
Friedemann Altrock commented on patch set 8 08/02/24, 14:27
For verification that this indeed makes IM7 work, use https://gist.github.com/fwg/7eb00ea5842e1bb07982ab3c80c1450b to enhance your DDEV setup with IM7. Then run branch main, go to Admin Tools > Environment > Test Images... and see it fail. Then apply this patch and see it work. For verification that this still works with IM6, do not add the Dockerfile, checkout the patch, and verify in the Admin Tools.GraphicalFunctions.php:634ReplySee other comment.GraphicalFunctions.php:634ReplyI think this comment was made in haste when seeing -
core-ci voted on patch set 8 V +1 08/02/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62744
-
Friedemann Altrock uploaded patch set 9
V +108/02/24, 14:39 -
core-ci voted on patch set 9 V +1 08/02/24, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62747
-
Friedemann Altrock commented on patch set 9 08/02/24, 14:48
Ups, had and old branch and lost the changelog. Restored and primed for 14.0.GraphicalFunctions.php:634Reply... this patch. -
Georg Ringer commented on patch set 9 08/02/24, 15:00
we don't yet start with v14 and will take at least until ~ 02/2025. I am not into the topic at all but can't we have that non breaking or maybe with a featureflag? -
Friedemann Altrock uploaded patch set 10
V +108/02/24, 15:50 -
Friedemann Altrock commented on patch set 10 08/02/24, 15:51
Reply
You are absolutely right. The reordering of composite command parameters can stay, this just makes the call in combineExec a little weird. -
core-ci voted on patch set 10 V -1 08/02/24, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62758
-
Friedemann Altrock uploaded patch set 11
V -108/02/24, 16:05 -
core-ci voted on patch set 11 V +1 08/02/24, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62759
-
Friedemann Altrock abandoned the change 08/02/24, 19:11
Could not acually reproduce. IM7 works :-) -
Friedemann Altrock restored the change 02/21/25, 14:42
-
Friedemann Altrock commented on patch set 11 02/21/25, 15:00
Could reproduce after all, getting a hint for a broken environment from @timo.webler@dkd.de helped. -
Friedemann Altrock rebased onto patch set 12
V +102/21/25, 15:02 -
core-ci voted on patch set 12 V +1 02/21/25, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74521
-
Garvin Hicking commented on patch set 12 09/18/25, 20:35
Is this still an issue with recent imagemagick? How would I have to set this up to reproduce? -
Timo Webler commented on patch set 12 09/19/25, 07:05
Reply
This issue exist on alpine. See https://forge.typo3.org/issues/91274#note-21 -
Benni Mack wrote 04/21/26, 14:57
Removed cc Benni Mack. -
Benni Mack commented on patch set 12 10/08/26, 09:13
13.4.29+ should include a change that fully supports IM7, fixed with f57eb441967, released in February 2026. I think we can close the issue and abandon this changeReply
Hey timo, can you retest this? I think it works now with Alpine 3.22, IM 7.1.2-15, whereas Alpine 3.21, IM 7.1.1-41 did not work. -
Timo Webler commented on patch set 12 10/08/26, 10:13
Reply
With the fix from https://forge.typo3.org/issues/108933, everything is now working. We have removed our patches from the projects. -
Benni Mack commented on patch set 12 10/08/26, 10:23
Reply Unresolved
Thank you, Timo, for the fast feedback! -
Benni Mack abandoned the change 10/08/26, 10:24
Fixed with #108933