Review 11.5 Merged

81262[BUGFIX] Toggle preview state in Form Editor

Andreas Kienast CR +2 V +2 Easy +6 −0 updated 09/27/23, 13:05

Commit message

When the form is in "Preview" mode and an integrator either saves or
switches to the form settings, the stage itself is updated to be in
"Edit" mode again, but the internal state remains in "Preview" mode,
causing glitches in the UI.

This patch now disables the preview state in the form model everytime
the "stage area", containing the editing interface, is rendered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/27/23, 10:11

  2. core-ci voted on patch set 1 V +1 09/27/23, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47227

  3. Stefan Bürk voted on patch set 1 CR +1 09/27/23, 12:59

  4. Stefan Bürk voted on patch set 1 V +1 09/27/23, 13:03

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 09/27/23, 13:05

  6. Andreas Kienast merged patch set 2 09/27/23, 13:05