Review main Abandoned Breaking

81267[WIP][!!!][FEATURE] Improve indexed_search

Georg Ringer CR 0 V 0 Expert +482 −519 updated 01/30/24, 07:14

Commit message

- simplify code
- remove not needed actions
- switch post to get
- remove js based pagination
- more formatting in fluid/vhs

ToDo:
- Testing
- Breaking RST (adapted templates, removed VHs)

Review

  • Code review CR 0
  • Verified V 0

Files 12

Review log 2946

Show 1421 earlier messages
  1. Georg Ringer uploaded patch set 1 09/27/23, 18:58

  2. core-ci voted on patch set 1 V -1 09/27/23, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47258

  3. Benni Mack uploaded patch set 2 V -1 01/03/24, 10:06

  4. core-ci voted on patch set 2 V -1 01/03/24, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51067

  5. Benni Mack marked it ready for review 01/03/24, 16:42

  6. Garvin Hicking commented on patch set 2 01/08/24, 22:21

    SearchController.php:598

    Just a note, I think this merge conflict didn't get resolved - I know it's WIP, but maybe if it slipped through it could help. It won't create a PHP parse error due to luckily being hidden inside of /** comment blocks :D
  7. Benni Mack uploaded patch set 3 V -1 01/09/24, 14:49

  8. Benni Mack commented on patch set 3 01/09/24, 14:49

    SearchController.php:598 Reply

    Done
  9. core-ci voted on patch set 3 V -1 01/09/24, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51340

  10. Benni Mack uploaded patch set 4 V -1 01/14/24, 19:21

  11. core-ci voted on patch set 4 V -1 01/14/24, 19:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51558

  12. Andreas Kienast commented on patch set 4 CR -2 01/23/24, 09:56

    on it, there's much more potential
  13. Andreas Kienast uploaded patch set 5 V -1 01/23/24, 11:10

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  14. core-ci voted on patch set 5 V -1 01/23/24, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51987

  15. Andreas Kienast uploaded patch set 6 V -1 01/23/24, 14:06

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  16. core-ci voted on patch set 6 V -1 01/23/24, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52000

  17. Andreas Kienast uploaded patch set 7 V -1 01/23/24, 14:37

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  18. Benni Mack commented on patch set 7 01/23/24, 14:41

    Form.html:91

    can we please get rid of the option and these rules? This is not 2000 anymore, and people now search and advanced search these days.
  19. core-ci voted on patch set 7 V -1 01/23/24, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52006

  20. Andreas Kienast commented on patch set 7 CR -2 01/23/24, 14:59

    Form.html:91 Reply

    Sure
  21. Stefan Bürk commented on patch set 7 01/23/24, 15:27

    Instead of introducing `int` typehints for the phash values it would better to refactor this towards proper hash fields (md5) and avoid the nasty `IndexedSearchUtility::md5inthash($val)` to castrate md5 hashes and producing duplicate key issues. https://review.typo3.org/c/Packages/TYPO3.CMS/+/74688 is a partly start for that. Something I wanted to go on with ... at least we should slighty coordinate on indexed_searched I would say.
  1. Andreas Kienast commented on patch set 7 01/23/24, 15:36

    Reply

    Can you give a rough estimate how long 74688 might take for you? Since it isn't considered a breaking change, it's less pressing than this refactoring patch, I assume?
  2. Benni Mack commented on patch set 7 01/23/24, 16:23

    Reply

    I think you can continue, all code is internal, and we then just change the signature afterwards again. OK?
  3. Andreas Kienast uploaded patch set 8 V -1 01/23/24, 17:05

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  4. Andreas Kienast uploaded patch set 9 01/23/24, 17:06

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 8 V -1 01/23/24, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52020

  6. core-ci voted on patch set 9 V -1 01/23/24, 17:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52021

  7. Stefan Bürk commented on patch set 9 01/23/24, 22:59

    Reply Unresolved

    The related patch is only partly and more needs to be done, and due to the db changes it's breaking also. But ack with Benni. Andreas, keep going - I will take the other change or start a new one starting with the database and rebase that later on this patch. Let's work in parallel (tomorrow).
  8. Andreas Kienast uploaded patch set 10 V -1 01/24/24, 09:32

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. core-ci voted on patch set 10 V -1 01/24/24, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52061

  10. Andreas Kienast uploaded patch set 11 V -1 01/25/24, 08:49

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  11. core-ci voted on patch set 11 V -1 01/25/24, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52138

  12. Benni Mack commented on patch set 11 01/25/24, 09:13

    Form.html:91 Reply

    Done
  13. Andreas Kienast uploaded patch set 12 V -1 01/25/24, 09:45

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  14. core-ci voted on patch set 12 V -1 01/25/24, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52145

  15. Andreas Kienast uploaded patch set 13 V -1 01/25/24, 10:35

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  16. core-ci voted on patch set 13 V -1 01/25/24, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52151

  17. Andreas Kienast uploaded patch set 14 V -1 01/25/24, 10:43

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  18. core-ci voted on patch set 14 V -1 01/25/24, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52152

  19. Benni Mack uploaded patch set 15 V -1 01/25/24, 11:25

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  20. core-ci voted on patch set 15 V -1 01/25/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52161

  21. Benni Mack rebased onto patch set 16 V -1 01/25/24, 12:33

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  22. core-ci voted on patch set 16 V -1 01/25/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52171

  23. Benni Mack uploaded patch set 17 V -1 01/25/24, 14:00

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  24. core-ci voted on patch set 17 V -1 01/25/24, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52183

  25. Benni Mack abandoned the change 01/30/24, 07:14

    I will abandon this patch now. This was a great resource, which we used to create 10+ other patches in other chunks and make Indeed Search better for v13. Thank you, Georg!