Review main Merged

81271[BUGFIX] Respect disabled pages in form navigation

Mathias Brodala CR +2 V +2 Easy +4 −4 updated 03/12/26, 06:54

Commit message

In case pages of a multi-step form are conditionally disabled using
variants, there may exist a previous or next page but it may be disabled.
Take this into account accordingly.

Notice that this does not work in case pages are disabled generally and
enabled using variants. (Reverse logic) This must be fixed separately.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2835

Show 810 earlier messages
  1. Mathias Brodala uploaded patch set 1 09/28/23, 08:47

  2. core-ci voted on patch set 1 V +1 09/28/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47271

  3. Andreas Kienast commented on patch set 1 09/28/23, 09:48

    Navigation.html:11

    Is it safe that `form.nextPage` always exists and is an object?
  4. Mathias Brodala commented on patch set 1 09/28/23, 10:10

    Navigation.html:11 Reply

    Yes, Fluid safely traverses object accessor paths and stops at the first absent segment: https://github.com/TYPO3/Fluid/blob/64f4e46fab194b180b4f5db4ca071eb3e01ae528/src/Core/Variables/StandardVariableProvider.php#L133
  5. Andreas Kienast commented on patch set 1 CR +1 09/28/23, 10:39

    Navigation.html:11 Reply

    Ack
  6. Thomas Hohn voted on patch set 1 CR +1 09/28/23, 12:24

  7. Mathias Brodala uploaded patch set 2 CR +1 V +1 10/04/23, 10:50

  8. core-ci voted on patch set 2 V +1 10/04/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47389

  9. Jasmina Ließmann voted on patch set 2 V +1 CR +1 10/25/23, 17:51

  10. Christian Kuhn voted on patch set 2 CR +1 10/26/23, 10:55

  1. Benjamin Franzke commented on patch set 2 V -1 10/26/23, 10:55

    on it (couldn't verify – I probably did sth. wrong)
  2. Mathias Brodala commented on patch set 2 10/26/23, 11:06

    Reply

  3. Benjamin Franzke commented on patch set 2 10/26/23, 12:02

    Reply

    I actually used an own example crafted from a customer form, but also with your second example from the issue I can not verify the change. If I do not check the checkbox, it shows the second page, and the second page shows "Next page" instead of "Submit" and leads to the 3rd page instead of submitting.
  4. Mathias Brodala commented on patch set 2 11/01/23, 10:30

    Reply

    Actually I just noticed that the example given is bad, it does not matter if the fix is applied because you always end up at the 3rd page with "Submit" then. I just posted a better example on Forge.
  5. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 10/18/24, 14:09

  6. Oliver Hader rebased onto patch set 4 03/25/25, 09:02

  7. core-ci voted on patch set 4 V +1 03/25/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76217

  8. Benni Mack wrote 03/28/25, 09:16

    Topic set to form
  9. Jasmina Ließmann wrote 02/04/26, 10:00

    Removed reviewer Jasmina Ließmann.
  10. Josua Vogel uploaded patch set 5 V +1 03/07/26, 09:59

  11. Josua Vogel updated the commit message in patch set 6 03/07/26, 09:59

  12. Josua Vogel commented on patch set 6 CR +1 V +1 03/07/26, 10:00

    Reply

    Works for me
  13. core-ci voted on patch set 6 V +1 03/07/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97546

  14. Josua Vogel commented on patch set 6 03/07/26, 10:13

    I would help with the backport, as there are two templates in v13 and v12.
  15. core-ci voted on patch set 5 V +1 03/07/26, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97545

  16. Josua Vogel uploaded patch set 7 CR +1 V +1 03/07/26, 10:45

  17. core-ci voted on patch set 7 V +1 03/07/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97547

  18. Josua Vogel voted on patch set 7 CR +1 V +1 03/07/26, 11:21

  19. Josua Vogel updated the commit message in patch set 8 CR +1 V +1 03/11/26, 20:32

  20. Josua Vogel voted on patch set 8 CR +1 V +1 03/11/26, 20:32

  21. core-ci voted on patch set 8 V +1 03/11/26, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97779

  22. Garvin Hicking voted on patch set 8 CR +1 V +1 03/12/26, 05:50

  23. Sven Liebert voted on patch set 8 CR +1 V +1 03/12/26, 05:53

  24. Georg Ringer voted on patch set 8 CR +2 V +2 03/12/26, 06:54

  25. Georg Ringer merged patch set 9 03/12/26, 06:54