81271[BUGFIX] Respect disabled pages in form navigation
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Josua Vogel +1
- Sven Liebert +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- Josua Vogel +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2835
Show 810 earlier messages
-
Mathias Brodala uploaded patch set 1 09/28/23, 08:47
-
core-ci voted on patch set 1 V +1 09/28/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47271
-
Andreas Kienast commented on patch set 1 09/28/23, 09:48
-
Mathias Brodala commented on patch set 1 09/28/23, 10:10
Navigation.html:11ReplyYes, Fluid safely traverses object accessor paths and stops at the first absent segment: https://github.com/TYPO3/Fluid/blob/64f4e46fab194b180b4f5db4ca071eb3e01ae528/src/Core/Variables/StandardVariableProvider.php#L133 -
Andreas Kienast commented on patch set 1 CR +1 09/28/23, 10:39
Navigation.html:11ReplyAck -
Thomas Hohn voted on patch set 1 CR +1 09/28/23, 12:24
-
Mathias Brodala uploaded patch set 2
CR +1V +110/04/23, 10:50 -
core-ci voted on patch set 2 V +1 10/04/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47389
-
Jasmina Ließmann voted on patch set 2 V +1 CR +1 10/25/23, 17:51
-
Christian Kuhn voted on patch set 2 CR +1 10/26/23, 10:55
-
Benjamin Franzke commented on patch set 2 V -1 10/26/23, 10:55
on it (couldn't verify – I probably did sth. wrong) -
Mathias Brodala commented on patch set 2 10/26/23, 11:06
Reply
Try the 2nd example in https://forge.typo3.org/issues/102055 -
Benjamin Franzke commented on patch set 2 10/26/23, 12:02
Reply
I actually used an own example crafted from a customer form, but also with your second example from the issue I can not verify the change. If I do not check the checkbox, it shows the second page, and the second page shows "Next page" instead of "Submit" and leads to the 3rd page instead of submitting. -
Mathias Brodala commented on patch set 2 11/01/23, 10:30
Reply
Actually I just noticed that the example given is bad, it does not matter if the fix is applied because you always end up at the 3rd page with "Submit" then. I just posted a better example on Forge. -
Oliver Hader updated the commit message in patch set 3
CR +1V +110/18/24, 14:09 -
Oliver Hader rebased onto patch set 4 03/25/25, 09:02
-
core-ci voted on patch set 4 V +1 03/25/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76217
-
Benni Mack wrote 03/28/25, 09:16
Topic set to form -
Jasmina Ließmann wrote 02/04/26, 10:00
Removed reviewer Jasmina Ließmann. -
Josua Vogel uploaded patch set 5
V +103/07/26, 09:59 -
Josua Vogel updated the commit message in patch set 6 03/07/26, 09:59
-
Josua Vogel commented on patch set 6 CR +1 V +1 03/07/26, 10:00
Reply
Works for me -
core-ci voted on patch set 6 V +1 03/07/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97546
-
Josua Vogel commented on patch set 6 03/07/26, 10:13
I would help with the backport, as there are two templates in v13 and v12. -
core-ci voted on patch set 5 V +1 03/07/26, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97545
-
Josua Vogel uploaded patch set 7
CR +1V +103/07/26, 10:45 -
core-ci voted on patch set 7 V +1 03/07/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97547
-
Josua Vogel voted on patch set 7 CR +1 V +1 03/07/26, 11:21
-
Josua Vogel updated the commit message in patch set 8
CR +1V +103/11/26, 20:32 -
Josua Vogel voted on patch set 8 CR +1 V +1 03/11/26, 20:32
-
core-ci voted on patch set 8 V +1 03/11/26, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97779
-
Garvin Hicking voted on patch set 8 CR +1 V +1 03/12/26, 05:50
-
Sven Liebert voted on patch set 8 CR +1 V +1 03/12/26, 05:53
-
Georg Ringer voted on patch set 8 CR +2 V +2 03/12/26, 06:54
-
Georg Ringer merged patch set 9 03/12/26, 06:54
Navigation.html:11