Review main Merged

81294[BUGFIX] Skip deleted translations in workspace

Achim Fritz CR +2 V +2 Easy +44 −1 updated 01/28/25, 12:40

Commit message

Do not show "Translate" Button if all translated
Content Elements are deleted.

Having one Content Element with a deleted Translation
should not show Translate Button in BackendLayout View.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2839

Show 1014 earlier messages
  1. Achim Fritz uploaded patch set 1 09/28/23, 12:05

  2. Achim Fritz uploaded patch set 2 09/28/23, 12:07

  3. core-ci voted on patch set 1 V +1 09/28/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47281

  4. core-ci voted on patch set 2 V +1 09/28/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47282

  5. Stefan Bürk commented on patch set 2 09/28/23, 14:38

    We normally start at the top `main` - backports are handled by core merge then.
  6. Stefan Bürk wrote 09/28/23, 14:38

    Change destination moved from 12.4 to main
  7. Stefan Bürk rebased onto patch set 3 09/28/23, 14:38

  8. Stefan Bürk commented on patch set 3 09/28/23, 14:39

    Reply

    moved to main.
  9. Stefan Bürk updated the commit message in patch set 4 09/28/23, 14:40

  10. Stefan Bürk commented on patch set 4 09/28/23, 14:46

    Not really sure as this implicts further UX confusiongs for editors. See comment in issue.
    Could need a better first line according to core contribution rules.

    ContentFetcher.php:217

    `andX()` / `orX()` are deprecated - use `and()` and `or()`

    ContentFetcher.php:232

    Main changed this to enums - but not rechecked yet. Additionally, check can be done using === then. Backport needs to revert to this then.
  11. core-ci voted on patch set 4 V -1 09/28/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47288

  12. core-ci voted on patch set 3 V -1 09/28/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47287

  13. Oliver Hader updated the commit message in patch set 5 V -1 10/18/24, 14:11

  14. Oliver Hader rebased onto patch set 6 12/17/24, 20:22

  1. core-ci voted on patch set 6 V -1 12/17/24, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71316

  2. Benni Mack uploaded patch set 7 V -1 01/21/25, 14:11

  3. core-ci voted on patch set 7 V +1 01/21/25, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72788

  4. Benni Mack commented on patch set 7 01/22/25, 08:01

    Reply

    Done

    ContentFetcher.php:217 Reply

    Done

    ContentFetcher.php:232 Reply

    Done
  5. Benni Mack uploaded patch set 8 V +1 01/22/25, 10:41

  6. Benni Mack voted on patch set 8 CR +1 V +1 01/22/25, 10:41

  7. Benni Mack commented on patch set 8 01/22/25, 10:42

    Reply

    I think the proposed solution is much better than the current state.
  8. core-ci voted on patch set 8 V +1 01/22/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72840

  9. Stefan Bürk commented on patch set 8 01/27/25, 09:37

    Reply

    Sorry, I don't think so. The "confusing" is only shifted, and not improved. Don't get me wrong, the change in general is okay - but I'd say that this **must** be combined with displaying the "delete translated regorcs in workspace" in some way (displaying but stating that they will be deleted" alond with a direct undelte or similar. With this change, it's quite confusing why the "translate" button is missing albeit no translated records are displayed. Granted, displaying the button but not beeing able to translate it is also wrong. We should talk about that - and not doing this simply shift, as otherwise we will get another issue report why the translate button is not shown and ending in a ping-pong work here.
  10. Christian Kuhn commented on patch set 8 01/27/25, 16:43

    Reply

    playing around, i have to agree: it would be good if some note is added stating some elements aren't shown because they have delete placeholders (or something better in better user understandable terms). i'll try to fiddle with the patch a bit.
  11. Christian Kuhn uploaded patch set 9 CR +1 V +1 01/28/25, 11:32

  12. core-ci voted on patch set 9 V -1 01/28/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73090

  13. Christian Kuhn uploaded patch set 10 V -1 01/28/25, 11:53

  14. Christian Kuhn commented on patch set 9 01/28/25, 11:57

    Reply

    Ok. I fiddled with this quite a while. The convoluted data structure makes everything much harder than it should be. I was unable to add a hint to single columns like "This column does not show some elements since they are deleted in this workspace". The best I could came up with is adding a badge in the header section of a language column: "Deleted workspace elements are not shown".
  15. Christian Kuhn uploaded patch set 11 01/28/25, 11:57

  16. Christian Kuhn commented on patch set 10 01/28/25, 11:57

    Reply

    i also slightly improved the code by suppressing the new query if user is not in workspace.
  17. core-ci voted on patch set 10 V -1 01/28/25, 11:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73091

  18. core-ci voted on patch set 11 V -1 01/28/25, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73092

  19. Christian Kuhn uploaded patch set 12 V -1 01/28/25, 12:09

  20. Stefan Bürk commented on patch set 11 01/28/25, 12:10

    Reply

    Having a minor information here helps, better than before. Fine with this.
  21. core-ci voted on patch set 12 V +1 01/28/25, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73093

  22. Christian Kuhn voted on patch set 12 CR +1 V +1 01/28/25, 12:17

  23. Stefan Bürk voted on patch set 12 CR +1 V +1 01/28/25, 12:17

  24. Christian Kuhn commented on patch set 12 CR +2 V +2 01/28/25, 12:25

    got a verbal "this is fine" from benni.
  25. Christian Kuhn merged patch set 13 01/28/25, 12:40