Review main Merged

81295[BUGFIX] Apply CKEditor5 CSS scoping client-side

Benjamin Franzke CR +2 V +2 Expert +481 −679 updated 10/02/23, 10:44

Commit message

Download CSS via fetch() and apply CSS scoping and
URL rebasing on the client in order to avoid the
need for a server side SASS wrapper that:
 * can not relocate relative paths
 * can not easily check if the resource is web accessible
 * had to use regex-replacements instead of straight
   forward replacements on a properly parsed syntax tree

Commands executed:
  composer remove scssphp/scssphp
  composer remove scssphp/scssphp -d typo3/sysext/core --no-update
  cd Build
  npm install --save css-tree
  npm install --save-dev @types/css-tree
  npm run build

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 23