81300[BUGFIX] Bring back page tree selection after reloading of tree
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1114
-
Łukasz Uznański uploaded patch set 1 09/29/23, 13:28
-
core-ci voted on patch set 1 V +1 09/29/23, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47306
-
Oli Bartsch commented on patch set 1 V -1 09/29/23, 13:41
This now leads to the fact that the "selected page" always jumps back to the one, stored while being in the page module for the last time. Additionally, this does not fix the initial bug report, that the selected page get's lost on refreshing the page tree via the corresponding button. -
Łukasz Uznański commented on patch set 1 10/02/23, 13:26
Reply
That's true, I will move it to other place. -
Łukasz Uznański uploaded patch set 2
V +110/02/23, 15:08 -
core-ci voted on patch set 2 V -1 10/02/23, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47355
-
Łukasz Uznański uploaded patch set 3
V -110/03/23, 08:38 -
core-ci voted on patch set 3 V +1 10/03/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47365
-
Stefan Bürk commented on patch set 3 CR -1 10/10/23, 07:53
This change has some flaws: If a user uses two (or more tabs) and navigates in the second tab through the page tree, and then click on the first tab in on the page tree reload button the last selected page from the other tab is shown as "selected" in the tree, but the page layout view still renders the "real" current page selected by the id param in that tab. That totally runs out of sync. Using the "session" is not a good option here. Sadly, I'm currently not having a better solution. Maybe it would be better to get the current selected page on the reload click, and select it afterwards dropping that temporary information again. Or send it with the ajax if the selection is done by the ajax call. So this should be more a JS/client side change I would say. Maybe some of the JS experts have here a better hint for this. However, using the session and that from the middle ware is not precise enough and opens side effects. -
Georg Ringer commented on patch set 3 10/10/23, 08:16
the URL looks like typo3/module/web/layout?id=310 > can't we just use the ID from the request? -
Łukasz Uznański commented on patch set 3 10/13/23, 11:53
Reply Unresolved
Ok, fair pointReply
It's true for page module, but this doesn't solve issue that Stefan mentioned. Also, while request tree data, it's a bit different endpoint -
Oliver Hader updated the commit message in patch set 4
CR -1V +110/18/24, 14:10 -
Oliver Hader updated the commit message in patch set 5 10/18/24, 14:10
-
Georg Ringer abandoned the change 03/23/25, 21:18
in the meantime this has been solved for v13, no backports planned for v12