Review main Merged

81301[BUGFIX] Prevent undefined array key "editlock" in DatabaseRecordList

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 10/02/23, 08:09

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 09/29/23, 13:53

  2. core-ci voted on patch set 1 V +1 09/29/23, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47307

  3. Oliver Klee voted on patch set 1 V +1 CR +1 09/29/23, 14:36

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/29/23, 14:58

  5. Nikita Hovratov commented on patch set 1 09/29/23, 15:28

    DatabaseRecordList.php:2184

    pages should always have `editlock` set in $row. I think this is only necessary to check for non-pages records.
  6. Oli Bartsch commented on patch set 1 V +2 CR +2 10/02/23, 08:09

    DatabaseRecordList.php:2184 Reply

    Usually all those checks are not necessary since this is misconfiguration (overriding pages TCA or not properly defining the editlock). Still, we should avoid PHP warnings in such cases IMO.
  7. Oli Bartsch merged patch set 2 10/02/23, 08:09