Review main Merged

81302[TASK] Avoid loose type comparison in PageLinkBuilder

Torben Hansen CR +2 V +2 Easy +3 −3 updated 09/30/23, 07:42

Commit message

There are currently 3 conditions in `PageLinkBuilder` which
use loose type comparison. All 3 conditions can safely be
replaced by strict type comparison.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Torben Hansen uploaded patch set 1 09/29/23, 16:41

  2. core-ci voted on patch set 1 V +1 09/29/23, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47312

  3. Oliver Klee voted on patch set 1 V +1 CR +1 09/29/23, 17:01

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 09/29/23, 20:40

  5. Georg Ringer voted on patch set 1 V +2 CR +2 09/30/23, 07:42

  6. Georg Ringer merged patch set 2 09/30/23, 07:42