Review 12.4 Merged

81308[BUGFIX] Apply CKEditor5 CSS scoping client-side

Benjamin Franzke CR +2 V +2 Expert +480 −596 updated 10/02/23, 10:47

Commit message

Download CSS via fetch() and apply CSS scoping and
URL rebasing on the client in order to avoid the
need for a server side SASS wrapper that:
 * can not relocate relative paths
 * can not easily check if the resource is web accessible
 * had to use regex-replacements instead of straight
   forward replacements on a properly parsed syntax tree

The composer dependency scssphp/scssphp could theoretically
be removed, but is kept in the v12 backport in order to
avoid breaking classic mode extensions that relied on the
fact that this dependency is shipped with TYPO3 v12.

Commands executed:
  cd Build
  npm install --save css-tree
  npm install --save-dev @types/css-tree
  npm run build

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 21