Review main Merged

81312[BUGFIX] Ensure working target attribute for link.page and link.action

Helmut Strasser CR +2 V +2 Normal +116 −11 updated 10/06/23, 14:54

Commit message

The `f:link.page` ViewHelper registers an attribute for
`target`, which works in extbase context. Due to some
changes, the ViewHelper has been enhanced to mitigate
the need for bootstrapping extbase in non-extbase
contexts. Therefore, `LinkFactory` (TypoLink) has been
used to build proper links in a non-extbase frontend
context with #98474.

The same principal for the different context has been
applied to the `f:link.action` ViewHelper with #101729.

That introduced a different behaviour between extbase
and non-extbase frontend context by simply overriding
the target attribute, if TypoLink generates one.

This change discards the build target from the
`LinkFactory` to behave equaly in non-extbase frontend
context compared to extbase context.

Additionally, tests are added to cover these cases to
the corresponding ViewHelper functional test cases.

Note: If TypoScript default target configuration is
      needed, the corresponding `f:link.typoscript`
      ViewHelper needs to be used.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 4