Review main Abandoned

81314[BUGFIX] Add eval for eval type 'year'

Łukasz Uznański CR 0 V 0 Easy +25 −1 updated 04/01/25, 05:54

Commit message

Add actual eval function for eval type 'year'. Check if year is
within possible timestamp value.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1621

  1. Łukasz Uznański uploaded patch set 1 10/03/23, 14:28

  2. core-ci voted on patch set 1 V -1 10/03/23, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47372

  3. Josef Glatz commented on patch set 1 10/04/23, 02:35

    just my opinion on the y2k38 unix time check: if those checks must be added here, check also for 64bit OS because than there‘s no need to tackle this stuff.
  4. Łukasz Uznański uploaded patch set 2 V -1 10/04/23, 07:33

  5. core-ci voted on patch set 2 V -1 10/04/23, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47383

  6. Łukasz Uznański uploaded patch set 3 V -1 10/04/23, 07:51

  7. core-ci voted on patch set 3 V +1 10/04/23, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47384

  8. Oliver Hader updated the commit message in patch set 4 V +1 10/18/24, 14:11

  9. Simon Schaufelberger rebased onto patch set 5 12/17/24, 18:51

  10. core-ci voted on patch set 5 V +1 12/17/24, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71311

  11. Garvin Hicking commented on patch set 5 CR -1 12/17/24, 21:56

    DataHandler.php:3022 Unresolved

    Hhm. timestamps can be signed, and then go below 0 - years like "1910" would be possible with negative value. Can you tell if this does not apply in this case, is the code only triggered for unsigned values?
  12. Simon Schaufelberger rebased onto patch set 6 CR -1 V +1 03/25/25, 11:30

  13. core-ci voted on patch set 6 V +1 03/25/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76242

  14. Benni Mack commented on patch set 6 CR -1 03/25/25, 12:26

    we need a test for this
  15. Benjamin Franzke commented on patch set 6 03/25/25, 14:09

    DataHandler.php:2881

    Hm, who is actually still running 32bit php? I don't think we should make our DataHandler behave differently based on the underlying execution environment in general.
  16. Benni Mack commented on patch set 6 03/25/25, 14:23

    DataHandler.php:2881 Reply

    that would mean we can close that patch / approach, I assume.
  17. Garvin Hicking commented on patch set 6 03/25/25, 14:31

    DataHandler.php:2881 Reply Unresolved

    Reading the issue again, this was more about the docs stating eval=year would respect "sane" year dates, which it doesn't. I would guess this should instead be solved with min/max values and setting like 'between 1900 and 2038' (we all know the world ends in 2038, so it's ok to set a fixed year here).
  18. Benni Mack marked it work in progress 03/27/25, 14:51

  19. Benni Mack commented on patch set 6 03/27/25, 14:52

    marking this one as WIP until we know if we actually need this change at all
  20. Benni Mack abandoned the change 03/31/25, 19:28

    why force a artifical limit on the year? I think we should adapt the docs.
  21. Georg Ringer commented on patch set 6 04/01/25, 05:54