Review main Merged

81316[BUGFIX] Add CKEditor5 migrator for {extraA,disa,a}llowedContent

Benjamin Franzke CR +2 V +2 Hard +348 −5 updated 10/06/23, 14:27

Commit message

Allowed content in CKEditor5 is to be configured via the
General HTML Support plugin option config.htmlSupport.
CKEditor4 style configs are now parsed and migrated.

Note that this config.htmlSupport only applies to elements that
are "known" to CKEditor5. Tags like "svg" or custom elements like
"<foo-bar>" are not configurable this way as `htmlSupport.(dis)allow`
can only handle elements that are defined in the CKEditor5 schema. [1]

Also reintroduce the default configuration that allows any class
and any attribute that starts with data- to be specified/preserved on
known tags. This was removed with #96874.

[1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html#enabling-custom-elements

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6