Review main Merged

81318[BUGFIX] Skip validation of form fields in disabled containers

Mathias Brodala CR +2 V +2 Easy +17 −1 updated 11/29/23, 04:42

Commit message

Aside from being disabled itself, a form field can also be placed in a
container which is disabled statically or using variants. In either case
the field must not be validated since it is not rendered and thus cannot
be filled by the user.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1319

  1. Mathias Brodala uploaded patch set 1 10/04/23, 10:10

  2. Mathias Brodala updated the commit message in patch set 2 10/04/23, 10:10

  3. core-ci voted on patch set 1 V +1 10/04/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47387

  4. core-ci voted on patch set 2 V +1 10/04/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47388

  5. Mathias Brodala uploaded patch set 3 V +1 10/04/23, 12:18

  6. Mathias Brodala uploaded patch set 4 10/04/23, 12:19

  7. core-ci voted on patch set 3 V -1 10/04/23, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47394

  8. core-ci voted on patch set 4 V +1 10/04/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47395

  9. Simon Schaufelberger voted on patch set 4 CR +1 11/27/23, 08:21

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 11/27/23, 11:38

  11. Benni Mack commented on patch set 5 CR +1 V +1 11/27/23, 14:27

    Published edit on patch set 4.
  12. Benni Mack voted on patch set 5 CR +1 V +1 11/27/23, 14:27

  13. core-ci voted on patch set 5 V -1 11/27/23, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50004

  14. Benni Mack rebased onto patch set 6 CR +1 V +1 11/27/23, 20:40

  15. core-ci voted on patch set 6 V +1 11/27/23, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50036

  16. Simon Schaufelberger voted on patch set 6 CR +1 11/28/23, 09:00

  17. Christian Kuhn voted on patch set 6 CR +1 V +1 11/28/23, 09:51

  18. Christian Kuhn commented on patch set 6 CR +2 V +2 11/29/23, 04:42

    merging together with the vote from benni on set 5.
  19. Christian Kuhn merged patch set 7 11/29/23, 04:42