Review main Merged

81323[TASK] Unbundle CKEditor5

Benjamin Franzke CR +2 V +2 Impossible +3213 −97344 updated 10/07/23, 05:15

Commit message

Unbundle CKEditor5 in order to be able to load plugins like "font" only
if actually configured, allowing TYPO3 core to ship *all* available
ckeditor5 modules without having to weigh in the downsides for large
modules that we do not want to ship for "every" installation.

All @ckeditor scoped npm packages provided by CKEditor5 are bundled into
an own small per-package bundle that is loaded (and linked to each
other) via our importmap infrastructure. This allows specific modules to
be loaded ondemand and has the additional advantage that plugin authors
can use modules via packages exports as suggested by upstream
documentation. This should lower the the barrier for writing custom
plugins.

The existing bundle @typo3/ckeditor5-bundle is still in
place and acts as wrapper for the split bundles. It is
deprecated and will be removed in TYPO3 v13.0.

Also worth noting is that terser is now used to
shrink the module size.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 69

Show 49 more files