Review 11.5 Merged

81324[TASK] Improve exception message for invalid `internal_type`

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 10/05/23, 10:04

Commit message

The exception message now contains the invalid
value as well as the only valid values.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/05/23, 09:53

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 10/05/23, 09:59

  3. core-ci voted on patch set 1 V +1 10/05/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47434

  4. Benni Mack voted on patch set 1 V +1 CR +1 10/05/23, 10:01

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 10/05/23, 10:04

  6. Oli Bartsch merged patch set 2 10/05/23, 10:04