Review main Abandoned

81326[WIP][TASK] QueryBuilder checks...

Oliver Hader CR 0 V 0 Normal +64 −36 updated 10/04/24, 15:55

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 4

Review log 813

  1. Oliver Hader uploaded patch set 1 10/05/23, 11:41

  2. core-ci voted on patch set 1 V -1 10/05/23, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47437

  3. Oliver Hader uploaded patch set 2 V -1 10/05/23, 13:11

  4. core-ci voted on patch set 2 V -1 10/05/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47442

  5. Oliver Hader uploaded patch set 3 V -1 10/05/23, 14:32

  6. core-ci voted on patch set 3 V -1 10/05/23, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47445

  7. Oliver Hader uploaded patch set 4 V -1 10/05/23, 19:11

  8. core-ci voted on patch set 4 V -1 10/05/23, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47448

  9. Oliver Hader rebased onto patch set 5 V -1 10/06/23, 11:55

  10. core-ci voted on patch set 5 V -1 10/06/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47484

  11. Garvin Hicking commented on patch set 5 11/20/23, 06:33

    hah, that's funny. Last week I thought that we could need something quite like this, running functional&acceptance tests with this in place should reveal a lot of potential issues. Wonder if there is any "legit" reason where a QB should/could be re-used.
  12. Garvin Hicking commented on patch set 5 11/21/23, 19:07

    (I think if you rebase this the tests may no longer fail, the acceptance tests were flakey due to a race condition that was fixed today)
  13. Oliver Hader abandoned the change 10/04/24, 15:55