Review main Merged

81328[BUGFIX] Use the correct return type for method copyRecord_raw

Simon Schaufelberger CR +2 V +2 Easy +1 −6 updated 10/06/23, 10:02

Commit message

DataHandler->copyRecord_raw can also return null.
This should be reflected in the doc header as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • Markus Klein +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Simon Schaufelberger uploaded patch set 1 10/05/23, 21:55

  2. core-ci voted on patch set 1 V -1 10/05/23, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47449

  3. Simon Schaufelberger uploaded patch set 2 V -1 10/06/23, 09:01

  4. core-ci voted on patch set 2 V +1 10/06/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47466

  5. Simon Praetorius voted on patch set 2 V +1 CR +1 10/06/23, 09:21

  6. Chris Müller voted on patch set 2 CR +1 10/06/23, 09:24

  7. Markus Klein voted on patch set 2 V +1 CR +1 10/06/23, 09:25

  8. Christian Kuhn commented on patch set 2 10/06/23, 09:49

    note we "usually" don't backport such stuff to v11 anymore. In this case I don't want to destroy valid votes though, and the patch applies to v11 without too many headaches, so I'll go for it.
  9. Christian Kuhn commented on patch set 2 V +1 CR +1 10/06/23, 09:54

    will probably merge soon.
  10. Christian Kuhn voted on patch set 2 V +2 CR +2 10/06/23, 10:02

  11. Christian Kuhn merged patch set 3 10/06/23, 10:02