Review 12.4 Merged

81337[BUGFIX] Improve CKEditor5 whitespace plugin usability

Benjamin Franzke CR +2 V +2 Normal +42 −41 updated 10/06/23, 13:40

Commit message

* Use insertText command as provided by @ckeditor/ckeditor5-typing
   to match the behaviour of the upstream specialcharacters plugin:
   * Place cursor after inserted text
   * Replace existing selection when applying the button/shortcut
   * Disable button in source-editing mode
     (also fix ckeditor5 integration to work in case source-editing
     mode is disabled, to be able to test/verify that case)
 * Add tooltip to the toolbar button
 * Add a shortcut hint to the toolbar button tooltip
 * Show consecutive softhyphens
 * Show selections on softhypens and non-breaking-spaces

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5