Review 12.4 Merged

81347[TASK] Use descriptions over placeholders in sys_file_storage

Nikita Hovratov CR +2 V +2 Easy +3 −3 updated 10/12/23, 11:16

Commit message

It is best practice to use permanently visible information to help to
fill out forms of any kind. In case of sys_file_storage the placeholder
is even partially cut off, so one can't read the whole text.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Nikita Hovratov commented on patch set 1 10/12/23, 11:08

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/12/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47712

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/12/23, 11:16

  4. Nikita Hovratov merged patch set 2 10/12/23, 11:16