Review main Merged

81360[TASK] Ship optional upstream CKEditor5 plugins

Benjamin Franzke CR +2 V +2 Hard +202 −64 updated 08/01/24, 19:03

Commit message

With the CKEditor5 unbundling in #102099, we can now ship free (GPL-2
licensed) CKEditor5 modules, that may be useful, for some installations,
without the need to ship them for all installations in a big bundle.

  npm install --save \
        @ckeditor/ckeditor5-highlight@41.4.2 \
        @ckeditor/ckeditor5-language@41.4.2 \
        @ckeditor/ckeditor5-mention@41.4.2
  npm run build

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 68

Show 48 more files

Review log 3146

Show 1321 earlier messages
  1. Benjamin Franzke uploaded patch set 1 10/06/23, 14:45

  2. Benjamin Franzke rebased onto patch set 2 10/06/23, 14:52

  3. core-ci voted on patch set 1 V -1 10/06/23, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47505

  4. core-ci voted on patch set 2 V +1 10/06/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47508

  5. Benjamin Franzke rebased onto patch set 3 V +1 10/06/23, 16:19

  6. core-ci voted on patch set 3 V +1 10/06/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47515

  7. Benjamin Franzke uploaded patch set 4 V +1 10/09/23, 07:27

  8. Benjamin Franzke marked it ready for review 10/09/23, 07:30

  9. core-ci voted on patch set 4 V +1 10/09/23, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47590

  10. Benjamin Franzke abandoned the change 10/09/23, 12:38

    It has been decided that documentation should be added, that described how to compile/ship these plugins in own extensions
  11. Benjamin Franzke restored the change 12/14/23, 08:19

  12. Benjamin Franzke marked it work in progress 12/14/23, 08:19

  13. Benjamin Franzke uploaded patch set 5 V +1 12/14/23, 08:19

  14. core-ci voted on patch set 5 V -1 12/14/23, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50640

  15. Benjamin Franzke rebased onto patch set 6 V -1 12/14/23, 08:45

  16. core-ci voted on patch set 6 V -1 12/14/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50644

  17. Benjamin Franzke uploaded patch set 7 V -1 02/12/24, 20:45

  18. core-ci voted on patch set 7 V +1 02/12/24, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53104

  19. Benjamin Franzke uploaded patch set 8 V +1 02/17/24, 08:36

  20. core-ci voted on patch set 8 V +1 02/17/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53270

  21. Benjamin Franzke uploaded patch set 9 V +1 02/19/24, 04:52

  1. core-ci voted on patch set 9 V +1 02/19/24, 04:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53323

  2. Benjamin Franzke voted on patch set 9 CR -1 02/19/24, 09:44

  3. Benjamin Franzke marked it work in progress 02/19/24, 10:29

  4. Georg Ringer uploaded patch set 10 CR -1 V +1 06/23/24, 14:33

  5. core-ci voted on patch set 10 V -1 06/23/24, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60113

  6. Georg Ringer rebased onto patch set 11 V -1 06/24/24, 07:45

  7. core-ci voted on patch set 11 V +1 06/24/24, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60161

  8. Georg Ringer commented on patch set 11 06/24/24, 09:36

    This change is ready for review.
  9. Georg Ringer marked it work in progress 06/24/24, 09:36

  10. Georg Ringer uploaded patch set 12 V +1 06/25/24, 11:27

  11. core-ci voted on patch set 12 V -1 06/25/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60284

  12. Georg Ringer uploaded patch set 13 V -1 06/25/24, 11:40

  13. core-ci voted on patch set 13 V +1 06/25/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60289

  14. Georg Ringer commented on patch set 13 06/25/24, 12:02

    This change is ready for review.
    I removed ckeditor5-html-embed, ckeditor5-media-embed and ckeditor5-pagebreak as require lots of HTML to be allowed what we maybe don't want
  15. Markus Klein commented on patch set 13 06/25/24, 13:49

    web-test-runner.config.mjs:166

    this is not in the package.json, or did I overlook it?
  16. Georg Ringer uploaded patch set 14 V +1 07/16/24, 07:45

  17. core-ci voted on patch set 14 V +1 07/16/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61613

  18. Benni Mack commented on patch set 14 07/16/24, 08:29

    I'm fine with the change if we remove "image" because IMO we need to have a better integration for the image plugin
  19. Georg Ringer uploaded patch set 15 V +1 07/16/24, 08:45

  20. Georg Ringer commented on patch set 15 07/16/24, 08:45

    web-test-runner.config.mjs:166 Reply

    Done
  21. core-ci voted on patch set 15 V +1 07/16/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61618

  22. Benjamin Franzke commented on patch set 15 CR +1 V +1 07/16/24, 09:23

    Reply

    Fine by me 👍
  23. Benni Mack voted on patch set 15 CR +1 V +1 07/16/24, 09:56

  24. Georg Ringer voted on patch set 15 CR +2 V +2 08/01/24, 19:03

  25. Georg Ringer merged patch set 16 08/01/24, 19:03