Review main Abandoned

81361[TASK] Make SvgTree self-aware of visibility

Benjamin Kott CR 0 V 0 Normal +27 −75 updated 02/06/24, 15:41

Commit message

The SvgTree is now self-aware of its visibility and updates
the rendering when the it becomes visible for the first time.
The "svg-tree:visible" event is now obsolete and is not needed
anymore, it was used to inform the svg tree that it is now
visible.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 12

Review log 79

  1. Benjamin Kott uploaded patch set 1 10/06/23, 15:04

  2. core-ci voted on patch set 1 V +1 10/06/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47509

  3. Benjamin Kott uploaded patch set 2 V +1 10/09/23, 12:58

  4. core-ci voted on patch set 2 V +1 10/09/23, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47594

  5. Benjamin Franzke voted on patch set 2 V +1 CR +1 10/09/23, 15:45

  6. Benni Mack voted on patch set 2 V +1 CR +1 10/10/23, 07:48

  7. Oliver Hader commented on patch set 2 10/10/23, 07:50

    svg-tree.ts:716 Unresolved

    I guess updating the view can happen for any intersecting entry once the observer callback is triggered...
  8. Benjamin Kott commented on patch set 2 CR -2 10/26/23, 09:49

    do not merge until we decide if we take https://review.typo3.org/c/Packages/TYPO3.CMS/+/81411 into v12 when it´s finished
  9. Benjamin Franzke abandoned the change 02/06/24, 15:41