Review main Merged

81366[FEATURE] Auto DB fields from TCA for type "color"

Christian Kuhn CR +2 V +2 Normal +80 −0 updated 10/06/23, 18:37

Commit message

Tables with TCA columns set to type="color" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=color.

Note the field length is for now set to varchar(7),
which should be enough to include a hex color
definition like "#123456". This should be fine, but
could easily extended in case we missed something.

There are no direct core usages of type=color, but
ext:styleguide confirms this change should be ok.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3