81367[!!!][TASK] Remove obscure TCA [types][bitmask_*] settings
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTypesShowitem.php+0 −49
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTypesShowitemTest.php+0 −96
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102108-TCATypesbitmask_Settings.rst4new+52 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+10 −0
Review log 1419
-
Christian Kuhn uploaded patch set 1 10/06/23, 18:49
-
core-ci voted on patch set 1 V +1 10/06/23, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47522
-
Oliver Klee commented on patch set 1 10/06/23, 19:16
typo: superseeded -> superseded -
Christian Kuhn uploaded patch set 2
V +110/06/23, 19:16 -
Christian Kuhn updated the commit message in patch set 3 10/06/23, 19:17
-
Christian Kuhn commented on patch set 3 10/06/23, 19:17
Reply
Done -
core-ci voted on patch set 2 V -1 10/06/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47523
-
core-ci voted on patch set 3 V -1 10/06/23, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47524
-
Christian Kuhn commented on patch set 4
V -110/06/23, 19:27Published edit on patch set 3. -
Christian Kuhn uploaded patch set 5 10/06/23, 19:27
-
Stefan Bürk voted on patch set 5 V +1 CR +1 10/06/23, 19:32
-
core-ci voted on patch set 4 V -1 10/06/23, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47525
-
core-ci voted on patch set 5 V +1 10/06/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47526
-
Christian Kuhn commented on patch set 5 10/06/23, 19:44
note: i'm not actively removing these setting in TcaMigration class: In case anyone uses this an still wants to continue to do so in some extension, it would be possible to override TcaTypesShowitem with an own solution and be done without other efforts. If we'd actively remove those settings in a TcaMigration, this process would become more troublesome, so we go with an extension scanner entry only, in this case. -
Oliver Klee voted on patch set 5 V +1 CR +1 10/06/23, 20:03
-
Stefan Bürk voted on patch set 5 V +2 CR +2 10/06/23, 20:12
-
Stefan Bürk merged patch set 6 10/06/23, 20:12
-
Simon Schaufelberger commented on patch set 6 10/06/23, 22:42
Breaking-102108-TCATypesbitmask_Settings.rst:34usedBreaking-102108-TCATypesbitmask_Settings.rst:46its would be correct here -
Christian Kuhn commented on patch set 6 10/11/23, 17:40
fixing tyos as drive-by in https://review.typo3.org/c/Packages/TYPO3.CMS/+/81413Breaking-102108-TCATypesbitmask_Settings.rst:34ReplyDoneBreaking-102108-TCATypesbitmask_Settings.rst:46ReplyDone