Review main Merged Breaking

81367[!!!][TASK] Remove obscure TCA [types][bitmask_*] settings

Christian Kuhn CR +2 V +2 Normal +62 −145 updated 10/11/23, 17:40

Commit message

There are two rather obsure TCA 'types' settings not many
people are aware of, and even less understand:

$GLOBALS['TCA']['someTable']['types']['bitmask_excludelist_bits']
$GLOBALS['TCA']['someTable']['types']['bitmask_value_field']

They are meant to be used to determine table record types
based on a bit field. That's probably because they can
usually be superseded having a string identifier for
type fields.

Looking through core and searching TER extension
code, both fields have never been used, ever.

The patch removes these options from TCA and documents
a workaround in the ReST file for those very rare cases
a custom extension actually uses this feature.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1419

  1. Christian Kuhn uploaded patch set 1 10/06/23, 18:49

  2. core-ci voted on patch set 1 V +1 10/06/23, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47522

  3. Oliver Klee commented on patch set 1 10/06/23, 19:16

    typo: superseeded -> superseded
  4. Christian Kuhn uploaded patch set 2 V +1 10/06/23, 19:16

  5. Christian Kuhn updated the commit message in patch set 3 10/06/23, 19:17

  6. Christian Kuhn commented on patch set 3 10/06/23, 19:17

    Reply

    Done
  7. core-ci voted on patch set 2 V -1 10/06/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47523

  8. core-ci voted on patch set 3 V -1 10/06/23, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47524

  9. Christian Kuhn commented on patch set 4 V -1 10/06/23, 19:27

    Published edit on patch set 3.
  10. Christian Kuhn uploaded patch set 5 10/06/23, 19:27

  11. Stefan Bürk voted on patch set 5 V +1 CR +1 10/06/23, 19:32

  12. core-ci voted on patch set 4 V -1 10/06/23, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47525

  13. core-ci voted on patch set 5 V +1 10/06/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47526

  14. Christian Kuhn commented on patch set 5 10/06/23, 19:44

    note: i'm not actively removing these setting in TcaMigration class: In case anyone uses this an still wants to continue to do so in some extension, it would be possible to override TcaTypesShowitem with an own solution and be done without other efforts. If we'd actively remove those settings in a TcaMigration, this process would become more troublesome, so we go with an extension scanner entry only, in this case.
  15. Oliver Klee voted on patch set 5 V +1 CR +1 10/06/23, 20:03

  16. Stefan Bürk voted on patch set 5 V +2 CR +2 10/06/23, 20:12

  17. Stefan Bürk merged patch set 6 10/06/23, 20:12

  18. Simon Schaufelberger commented on patch set 6 10/06/23, 22:42

    Breaking-102108-TCATypesbitmask_Settings.rst:34

    used

    Breaking-102108-TCATypesbitmask_Settings.rst:46

    its would be correct here
  19. Christian Kuhn commented on patch set 6 10/11/23, 17:40

    Breaking-102108-TCATypesbitmask_Settings.rst:34 Reply

    Done

    Breaking-102108-TCATypesbitmask_Settings.rst:46 Reply

    Done