Review main Merged

81370[TASK] Bump phpunit and phpstan

Christian Kuhn CR +2 V +2 Normal +85 −76 updated 10/07/23, 10:09

Commit message

phpunit 10.4.0 brings minor changed type annotations
which phpstan isn't happy with. We bump both deps now.

> composer req --dev phpstan/phpstan:^1.10.38
> composer req --dev phpunit/phpunit:^10.4.0 -w
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 610

  1. Christian Kuhn uploaded patch set 1 10/07/23, 07:58

  2. Christian Kuhn rebased onto patch set 2 10/07/23, 07:59

  3. core-ci voted on patch set 2 V +1 10/07/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47535

  4. core-ci voted on patch set 1 V +1 10/07/23, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47534

  5. Oliver Klee voted on patch set 2 V +1 CR +1 10/07/23, 08:14

  6. core-ci voted on patch set 2 V -1 10/07/23, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47536

  7. core-ci voted on patch set 2 V +1 10/07/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47536

  8. Christian Kuhn commented on patch set 2 V +2 CR +2 10/07/23, 10:07

    i'll bring this in to happify nightly again.
  9. Christian Kuhn merged patch set 3 10/07/23, 10:07

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 10/07/23, 10:09