Review 12.4 Merged

81371[TASK] Bump phpunit and phpstan

Christian Kuhn CR +2 V +2 Normal +92 −82 updated 10/07/23, 10:10

Commit message

phpunit 10.4.0 brings minor changed type annotations
which phpstan isn't happy with. We bump both deps now.

> composer req --dev phpstan/phpstan:^1.10.38
> composer req --dev phpunit/phpunit:^10.4.0 -w
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/07/23, 09:31

  2. core-ci voted on patch set 1 V +1 10/07/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47539

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/07/23, 10:08

  4. Christian Kuhn merged patch set 2 10/07/23, 10:08

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/07/23, 10:10