81373[!!!][TASK] Remove legacy setting 'GFX/gdlib'
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −3
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102113-RemovedLegacySettingGFXgdlib.rstnew+34 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+13 −15
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+5 −10
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+1 −1
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
Review log 1417
-
Andreas Nedbal uploaded patch set 1 10/07/23, 17:18
-
Oliver Klee voted on patch set 1 CR +1 10/07/23, 17:21
-
core-ci voted on patch set 1 V -1 10/07/23, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47542
-
Andreas Nedbal uploaded patch set 2
CR +1V -110/07/23, 17:31 -
Oliver Klee voted on patch set 2 CR +1 10/07/23, 17:36
-
core-ci voted on patch set 2 V +1 10/07/23, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47543
-
Nikita Hovratov voted on patch set 2 CR +1 10/07/23, 17:48
-
Garvin Hicking commented on patch set 2 10/07/23, 18:22
I see two extensions that check for $GLOBALS['TYPO3_CONF_VARS']['GFX']['gdlib'] to be set/true to perform code: IchHabRecht/filefill and franzholz/div2007. I think the BC RST should probably mention, that extensions should no longer check this configuration option to perform custom operations, and instead also check for the GDLib class? Since I don't think many other extensions use that (I scanned all typo3-extensions listed in packagist) it doesn't rectify keeping the option and just auto-setting it, and cluttering the code... -
Simon Schaufelberger commented on patch set 2 10/07/23, 20:27
ContentObjectRenderer.php:3658I'm surprised why the GifBuilder calss is instanciated even before checking if it can do something for us because there is no other usage of this class down below. I suggest to move the gifCreator inside the if. -
Benni Mack uploaded patch set 3
CR +1V +110/07/23, 21:44 -
Simon Schaufelberger commented on patch set 3 10/07/23, 21:51
ContentObjectRenderer.php:3658ReplyDone -
core-ci voted on patch set 3 V +1 10/07/23, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47546
-
Oliver Klee voted on patch set 3 CR +1 10/08/23, 08:58
-
Simon Schaufelberger voted on patch set 3 V +1 CR +1 10/08/23, 11:52
-
Oliver Klee voted on patch set 3 V +1 10/08/23, 12:12
-
Andreas Nedbal voted on patch set 3 V +2 CR +2 10/08/23, 17:07
-
Andreas Nedbal merged patch set 4 10/08/23, 17:08