Review main Merged

81380[TASK] Avoid superfluous SQL query in RecordsContentObject

Christoph Lehmann CR +2 V +2 Normal +40 −35 updated 11/29/23, 16:06

Commit message

Don't check accessibility to current page again. This is already
done in the TypoScriptFrontendController.

In addition some PHPStan issues are resolved.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2129

Show 34 earlier messages
  1. Christoph Lehmann uploaded patch set 1 10/08/23, 18:36

  2. Christoph Lehmann commented on patch set 1 10/08/23, 18:40

    11.5 is also affected.
  3. core-ci voted on patch set 1 V +1 10/08/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47566

  4. Christoph Lehmann commented on patch set 1 10/08/23, 19:03

    The same was already done in https://forge.typo3.org/issues/100372
  1. Christoph Lehmann updated the commit message in patch set 2 V +1 10/28/23, 14:31

  2. core-ci voted on patch set 2 V +1 10/28/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48329

  3. Benni Mack commented on patch set 2 10/30/23, 07:52

    RecordsContentObject.php:113

    what if we're not checking "tt_content" but actually "pages"?
  4. Benni Mack commented on patch set 2 10/30/23, 07:59

    RecordsContentObject.php:113 Reply

    maybe we move this just into a separate method?
  5. Christoph Lehmann uploaded patch set 3 V +1 10/30/23, 15:58

  6. Christoph Lehmann commented on patch set 3 10/30/23, 15:59

    RecordsContentObject.php:113 Reply

    Good catch with pages table!
  7. core-ci voted on patch set 3 V -1 10/30/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48363

  8. Benni Mack commented on patch set 3 10/30/23, 16:14

    RecordsContentObject.php:149

    let's do an (int) cast here
  9. Christoph Lehmann uploaded patch set 4 V -1 10/30/23, 18:47

  10. core-ci voted on patch set 4 V +1 10/30/23, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48367

  11. Christoph Lehmann uploaded patch set 5 V +1 10/30/23, 18:58

  12. Christoph Lehmann commented on patch set 5 10/30/23, 19:01

    RecordsContentObject.php:149 Reply

    Done. Also removed !empty($val['table'] because it must have triggered an undefined array key warning before.
  13. core-ci voted on patch set 5 V +1 10/30/23, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48368

  14. Christoph Lehmann rebased onto patch set 6 V +1 11/23/23, 10:32

  15. core-ci voted on patch set 6 V +1 11/23/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49633

  16. Benni Mack voted on patch set 6 CR +1 11/27/23, 14:26

  17. Oli Bartsch commented on patch set 6 CR -1 11/29/23, 10:46

    RecordsContentObject.php:68

    Let's keep the Null coalescing operator, since this is not relevant for the patch and this should be backported.
  18. Oli Bartsch uploaded patch set 7 CR +1 V +1 11/29/23, 10:47

  19. Oli Bartsch commented on patch set 7 CR +1 V +1 11/29/23, 10:47

    RecordsContentObject.php:68 Reply

    Done
  20. core-ci voted on patch set 7 V -1 11/29/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50104

  21. Oli Bartsch uploaded patch set 8 CR +1 V +1 11/29/23, 12:31

  22. core-ci voted on patch set 8 V +1 11/29/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50113

  23. Benni Mack voted on patch set 8 CR +1 V +1 11/29/23, 12:57

  24. Oli Bartsch voted on patch set 8 CR +2 V +2 11/29/23, 16:06

  25. Oli Bartsch merged patch set 9 11/29/23, 16:06