81380[TASK] Avoid superfluous SQL query in RecordsContentObject
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2129
Show 34 earlier messages
-
Christoph Lehmann uploaded patch set 1 10/08/23, 18:36
-
Christoph Lehmann commented on patch set 1 10/08/23, 18:40
11.5 is also affected. -
core-ci voted on patch set 1 V +1 10/08/23, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47566
-
Christoph Lehmann commented on patch set 1 10/08/23, 19:03
The same was already done in https://forge.typo3.org/issues/100372
-
Christoph Lehmann updated the commit message in patch set 2
V +110/28/23, 14:31 -
core-ci voted on patch set 2 V +1 10/28/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48329
-
Benni Mack commented on patch set 2 10/30/23, 07:52
RecordsContentObject.php:113what if we're not checking "tt_content" but actually "pages"? -
Benni Mack commented on patch set 2 10/30/23, 07:59
RecordsContentObject.php:113Replymaybe we move this just into a separate method? -
Christoph Lehmann uploaded patch set 3
V +110/30/23, 15:58 -
Christoph Lehmann commented on patch set 3 10/30/23, 15:59
RecordsContentObject.php:113ReplyGood catch with pages table! -
core-ci voted on patch set 3 V -1 10/30/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48363
-
Benni Mack commented on patch set 3 10/30/23, 16:14
RecordsContentObject.php:149let's do an (int) cast here -
Christoph Lehmann uploaded patch set 4
V -110/30/23, 18:47 -
core-ci voted on patch set 4 V +1 10/30/23, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48367
-
Christoph Lehmann uploaded patch set 5
V +110/30/23, 18:58 -
Christoph Lehmann commented on patch set 5 10/30/23, 19:01
RecordsContentObject.php:149ReplyDone. Also removed !empty($val['table'] because it must have triggered an undefined array key warning before. -
core-ci voted on patch set 5 V +1 10/30/23, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48368
-
Christoph Lehmann rebased onto patch set 6
V +111/23/23, 10:32 -
core-ci voted on patch set 6 V +1 11/23/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49633
-
Benni Mack voted on patch set 6 CR +1 11/27/23, 14:26
-
Oli Bartsch commented on patch set 6 CR -1 11/29/23, 10:46
RecordsContentObject.php:68Let's keep the Null coalescing operator, since this is not relevant for the patch and this should be backported. -
Oli Bartsch uploaded patch set 7
CR +1V +111/29/23, 10:47 -
Oli Bartsch commented on patch set 7 CR +1 V +1 11/29/23, 10:47
RecordsContentObject.php:68ReplyDone -
core-ci voted on patch set 7 V -1 11/29/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50104
-
Oli Bartsch uploaded patch set 8
CR +1V +111/29/23, 12:31 -
core-ci voted on patch set 8 V +1 11/29/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50113
-
Benni Mack voted on patch set 8 CR +1 V +1 11/29/23, 12:57
-
Oli Bartsch voted on patch set 8 CR +2 V +2 11/29/23, 16:06
-
Oli Bartsch merged patch set 9 11/29/23, 16:06