Review main Merged

81389[BUGFIX] Fix type checks for T3D import of with missing files/TCA

Garvin Hicking CR +2 V +2 Normal +60 −7 updated 10/26/23, 12:36

Commit message

See the issue for an example snippet and original bug report on
StackOverflow.

Also updates the documentation to reflect dealing with issues
like these.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2027

Show 12 earlier messages
  1. Garvin Hicking uploaded patch set 1 10/09/23, 16:16

  2. core-ci voted on patch set 1 V +1 10/09/23, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47608

  1. Oliver Klee commented on patch set 1 10/09/23, 16:47

    ImportExport.php:765

    If I read the code correctly, there now are cases where `$line['msg`]` is not set yet when we reach this line. Maybe we can add an `else` case above and set `$line['msg`]` to an empty string.
  2. Garvin Hicking commented on patch set 1 10/09/23, 17:00

    ImportExport.php:765 Reply

    It is set to an empty string in line 720?
  3. Oliver Klee commented on patch set 1 10/09/23, 17:04

    ImportExport.php:765 Reply

    Ah, indeed. I missed that. Thanks!
  4. Garvin Hicking commented on patch set 1 10/09/23, 17:25

    ImportExport.php:765 Reply

    Thanks a lot for looking. This is the first time I dove into T3D and I hope to have fixed the issue at hand with the least amount of intrusion that doesn't interfer, so having more eyes at this is much appreciated :-)
  5. Garvin Hicking uploaded patch set 2 V +1 10/11/23, 14:05

  6. core-ci voted on patch set 2 V +1 10/11/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47685

  7. Garvin Hicking rebased onto patch set 3 V +1 10/26/23, 10:49

    The following files contain Git conflicts: * typo3/sysext/impexp/Classes/Import.php
  8. Garvin Hicking uploaded patch set 4 10/26/23, 10:53

  9. Garvin Hicking uploaded patch set 5 10/26/23, 10:55

  10. Garvin Hicking uploaded patch set 6 10/26/23, 11:00

  11. Garvin Hicking marked it ready for review 10/26/23, 11:01

  12. core-ci voted on patch set 4 V +1 10/26/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48223

  13. core-ci voted on patch set 3 V -1 10/26/23, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48222

  14. core-ci voted on patch set 6 V +1 10/26/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48226

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 10/26/23, 11:09

  16. core-ci voted on patch set 5 V +1 10/26/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48224

  17. Benni Mack commented on patch set 6 CR -1 10/26/23, 11:29

    if you backport this into v12, the ImportantFile needs to go into v12.4.x folder
  18. Garvin Hicking updated the commit message in patch set 7 CR +1 V +1 10/26/23, 11:32

  19. Garvin Hicking commented on patch set 7 10/26/23, 11:35

    Reply

    Sorry; no, the patch was't meant to be ported back to v12. My rebasing went awry, so that change in the commit got lost. Adjusted now. Backporting is probably not recommended because the mentioned refactoring only takes place in main. Unsure about whether the change to the documentation file `EXT:impexp/Documentation/Introduction/index.rst` could/should be backported though, but ideally I wouldn't want to create a distinct patch for this...?
  20. core-ci voted on patch set 7 V +1 10/26/23, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48230

  21. Christian Kuhn commented on patch set 7 V +1 CR +1 10/26/23, 11:57

    Reply

    yeah. let's keep the docs change, but scratch the important.rst in the backport.
  22. Oliver Klee voted on patch set 7 CR +1 10/26/23, 12:22

  23. Stefan Bürk voted on patch set 7 V +2 CR +2 10/26/23, 12:31

  24. Stefan Bürk merged patch set 8 10/26/23, 12:31

  25. Christian Kuhn commented on patch set 8 10/26/23, 12:36

    Reply

    ok, no backport anyway. did misread this detail.