81389[BUGFIX] Fix type checks for T3D import of with missing files/TCA
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2027
Show 12 earlier messages
-
Garvin Hicking uploaded patch set 1 10/09/23, 16:16
-
core-ci voted on patch set 1 V +1 10/09/23, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47608
-
Oliver Klee commented on patch set 1 10/09/23, 16:47
-
Garvin Hicking commented on patch set 1 10/09/23, 17:00
ImportExport.php:765ReplyIt is set to an empty string in line 720? -
Oliver Klee commented on patch set 1 10/09/23, 17:04
ImportExport.php:765ReplyAh, indeed. I missed that. Thanks! -
Garvin Hicking commented on patch set 1 10/09/23, 17:25
ImportExport.php:765ReplyThanks a lot for looking. This is the first time I dove into T3D and I hope to have fixed the issue at hand with the least amount of intrusion that doesn't interfer, so having more eyes at this is much appreciated :-) -
Garvin Hicking uploaded patch set 2
V +110/11/23, 14:05 -
core-ci voted on patch set 2 V +1 10/11/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47685
-
Garvin Hicking rebased onto patch set 3
V +110/26/23, 10:49The following files contain Git conflicts: * typo3/sysext/impexp/Classes/Import.php -
Garvin Hicking uploaded patch set 4 10/26/23, 10:53
-
Garvin Hicking uploaded patch set 5 10/26/23, 10:55
-
Garvin Hicking uploaded patch set 6 10/26/23, 11:00
-
Garvin Hicking marked it ready for review 10/26/23, 11:01
-
core-ci voted on patch set 4 V +1 10/26/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48223
-
core-ci voted on patch set 3 V -1 10/26/23, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48222
-
core-ci voted on patch set 6 V +1 10/26/23, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48226
-
Christian Kuhn voted on patch set 6 V +1 CR +1 10/26/23, 11:09
-
core-ci voted on patch set 5 V +1 10/26/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48224
-
Benni Mack commented on patch set 6 CR -1 10/26/23, 11:29
if you backport this into v12, the ImportantFile needs to go into v12.4.x folder -
Garvin Hicking updated the commit message in patch set 7
CR +1V +110/26/23, 11:32 -
Garvin Hicking commented on patch set 7 10/26/23, 11:35
Reply
Sorry; no, the patch was't meant to be ported back to v12. My rebasing went awry, so that change in the commit got lost. Adjusted now. Backporting is probably not recommended because the mentioned refactoring only takes place in main. Unsure about whether the change to the documentation file `EXT:impexp/Documentation/Introduction/index.rst` could/should be backported though, but ideally I wouldn't want to create a distinct patch for this...? -
core-ci voted on patch set 7 V +1 10/26/23, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48230
-
Christian Kuhn commented on patch set 7 V +1 CR +1 10/26/23, 11:57
Reply
yeah. let's keep the docs change, but scratch the important.rst in the backport. -
Oliver Klee voted on patch set 7 CR +1 10/26/23, 12:22
-
Stefan Bürk voted on patch set 7 V +2 CR +2 10/26/23, 12:31
-
Stefan Bürk merged patch set 8 10/26/23, 12:31
-
Christian Kuhn commented on patch set 8 10/26/23, 12:36
Reply
ok, no backport anyway. did misread this detail.
ImportExport.php:765