Review 12.4 Merged

81397[BUGFIX] Add font plugin to CKEditor5

Benjamin Franzke CR +2 V +2 Hard +272 −62 updated 02/19/24, 04:47

Commit message

Add the configuration to the "Full" RTE preset, and also
include some modules that missed in Full preset since #102099.

npm install --save @ckeditor/ckeditor5-font@41.1.0
npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 67

Show 47 more files

Review log 710

  1. Benjamin Franzke uploaded patch set 1 10/10/23, 07:27

  2. core-ci voted on patch set 1 V +1 10/10/23, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47640

  3. David Bruchmann commented on patch set 1 12/13/23, 16:41

    Full.yaml:94

    I still had to add this line in the yaml file: - { 'module': '@ckeditor/ckeditor5-table', exports: ['Table', 'TableToolbar', 'TableProperties', 'TableCellProperties', 'TableCaption'] }
  4. Benjamin Franzke uploaded patch set 2 V +1 12/14/23, 16:29

  5. core-ci voted on patch set 2 V +1 12/14/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50657

  6. Benjamin Franzke uploaded patch set 3 V +1 02/19/24, 04:39

  7. Benjamin Franzke marked it ready for review 02/19/24, 04:39

  8. Benjamin Franzke commented on patch set 3 02/19/24, 04:43

    Full.yaml:94 Reply

    That is included in Build/Sources/TypeScript/rte_ckeditor/ckeditor5.ts
  9. core-ci voted on patch set 3 V +1 02/19/24, 04:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53321

  10. Benjamin Franzke merged patch set 4 02/19/24, 04:47