81398[BUGFIX] Fix another PHP 8 warning in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Philipp Kitzberger uploaded patch set 1 10/10/23, 08:06
-
core-ci voted on patch set 1 V +1 10/10/23, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47643
-
Oliver Klee voted on patch set 1 V +1 CR +1 10/10/23, 09:33
-
Oliver Hader commented on patch set 1 CR -1 10/10/23, 10:07
-
Christian Kuhn uploaded patch set 2
CR +1V +110/15/23, 13:01 -
Christian Kuhn commented on patch set 1 10/15/23, 13:01
DataHandler.php:7768Replyyeah. or even more explicit: ($this->suggestedInsertUids[$table . ':' . $suggestedUid] ?? false) $this->suggestedInsertUids is a bit opaque currently: ext:impexp only uses it to set value to "DELETE", and testing-framework sets some values to 'true'. As such, a null coalescing should be fine here, but !empty() would do, too. -
Christian Kuhn voted on patch set 2 V +1 CR +1 10/15/23, 13:01
-
core-ci voted on patch set 2 V +1 10/15/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47775
-
Simon Schaufelberger voted on patch set 2 V +1 CR +1 10/15/23, 13:12
-
Oliver Klee voted on patch set 2 V +1 CR +1 10/15/23, 13:20
-
Stefan Bürk voted on patch set 2 V +2 CR +2 10/15/23, 13:39
-
Stefan Bürk merged patch set 3 10/15/23, 13:53
DataHandler.php:7768