Review main Merged

81408[TASK] Improve ReferenceIndex details

Christian Kuhn CR +2 V +2 Hard +301 −424 updated 10/11/23, 09:22

Commit message

The ReferenceIndex class with table 'sys_refindex' plays
a more and more important role in core when it comes to
systematic performance improvements.

We've had quite some work on sys_refindex in v11 already,
but the main class has not been touched much, yet.

It's time to untangle some more to unblock further works.

The patch brings some general changes to the @internal
marked class ReferenceIndex:

* Rely on DI
* Set PHP types that can be forced easily
* Tame more class state
* Streamline the CLI main method used with
  > bin/typo3 referenceindex:update

The changes in updateIndex() improve the overall output
of the CLI processing: For instance, tables are now
processed alphabetically, and there are changes like
more effective calls for tables that have no relations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1216

  1. Christian Kuhn uploaded patch set 1 10/10/23, 19:55

  2. core-ci voted on patch set 1 V -1 10/10/23, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47663

  3. Christian Kuhn uploaded patch set 2 V -1 10/10/23, 20:34

  4. core-ci voted on patch set 2 V +1 10/10/23, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47665

  5. Christian Kuhn uploaded patch set 3 V +1 10/10/23, 21:03

  6. core-ci voted on patch set 3 V +1 10/10/23, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47666

  7. Stefan Bürk commented on patch set 3 10/10/23, 21:33

    ReferenceIndex.php:939

    Should be `$subQueryBuilder->quoteIdentifier()` here ... was wrong before, but would really be safer IMO to us ethe same instance building the query. Mitigates future issues checking why another queryBuilder is used here - eventually.
  8. Christian Kuhn commented on patch set 3 10/10/23, 21:36

    ReferenceIndex.php:939 Reply

    oh. missed that on reading. please adapt.
  9. Stefan Bürk uploaded patch set 4 V +1 10/10/23, 21:44

  10. Stefan Bürk commented on patch set 4 CR +1 10/10/23, 21:49

    ReferenceIndex.php:939 Reply

    Done
  11. core-ci voted on patch set 4 V +1 10/10/23, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47667

  12. Stefan Bürk voted on patch set 4 V +1 10/10/23, 22:05

  13. Oliver Klee voted on patch set 4 V +1 10/11/23, 08:57

  14. Oliver Klee voted on patch set 4 CR +1 10/11/23, 08:59

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 10/11/23, 09:20

  16. Christian Kuhn merged patch set 5 10/11/23, 09:22