Review main Merged

81412[BUGFIX] Change to "move elements" when using cut in file list dot-menu

Kevin Appelt CR +2 V +2 Easy +1 −2 updated 10/15/23, 14:18

Commit message

Make sure the clipboard action gets changed to move if the user chooses cut in the dot menu.
Only the dot-menu in the list view was affected.

Also removes an unused variable.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Kevin Appelt uploaded patch set 1 10/11/23, 14:56

  2. core-ci voted on patch set 1 V +1 10/11/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47686

  3. Garvin Hicking commented on patch set 1 V +1 CR +1 10/11/23, 15:52

    Nice! Works for me!

    FileList.php:1284

    This seems like a leftover, too? There's no $actions variable in this method.
  4. Kevin Appelt uploaded patch set 2 CR +1 V +1 10/13/23, 08:43

  5. Garvin Hicking commented on patch set 2 V +1 CR +1 10/13/23, 08:47

    FileList.php:1284 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/13/23, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47734

  7. Kevin Appelt commented on patch set 2 10/13/23, 08:50

    FileList.php:1284 Reply

    Done
  8. Jasmina Ließmann voted on patch set 2 V +1 CR +1 10/15/23, 13:46

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 10/15/23, 13:58

  10. Stefan Bürk voted on patch set 2 V +1 CR +1 10/15/23, 14:01

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 10/15/23, 14:18

  12. Stefan Bürk merged patch set 3 10/15/23, 14:18