Review main Merged

81414[TASK] Clean up GifBuilder code

Benni Mack CR +2 V +2 Normal +71 −86 updated 10/12/23, 08:29

Commit message

This change avoids using the `$this->im`
property which is the resource pointer to the
`\GdImage` object.

In addition, the method `gifBuild()` is the only place
to deal with absolute path and the actual path
prefix, making `fileName()` easier to understand.

This change will then allow to advance with
Gdlib, adding support for webp at the next stage.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1