Review main Merged Breaking

81418[!!!][TASK] Always add xml prologue in flexArray2Xml()

Christian Kuhn CR +2 V +2 Normal +55 −13 updated 10/12/23, 12:31

Commit message

There is no point in not adding the XML prologue
when using FlexFormTools->flexArray2Xml(). We
can remove the second argument to always add it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1013

  1. Christian Kuhn uploaded patch set 1 10/12/23, 11:22

  2. core-ci voted on patch set 1 V +1 10/12/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47713

  3. Christian Kuhn uploaded patch set 2 V +1 10/12/23, 11:54

  4. Garvin Hicking commented on patch set 2 V +1 CR +1 10/12/23, 11:58

    💯
  5. core-ci voted on patch set 2 V -1 10/12/23, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47715

  6. Oliver Klee voted on patch set 2 CR +1 10/12/23, 12:02

  7. Christian Kuhn uploaded patch set 3 CR +1 V +1 10/12/23, 12:02

  8. Oliver Klee voted on patch set 3 CR +1 10/12/23, 12:03

  9. Garvin Hicking voted on patch set 3 V +1 CR +1 10/12/23, 12:05

  10. core-ci voted on patch set 3 V +1 10/12/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47716

  11. Benni Mack voted on patch set 3 V +1 CR +1 10/12/23, 12:30

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 10/12/23, 12:31

  13. Christian Kuhn merged patch set 4 10/12/23, 12:31