Review main Abandoned

81423[BUGFIX] Improve pagination of tile view in filelist

Georg Ringer CR 0 V 0 Easy +16 −34 updated 02/04/26, 20:21

Commit message

The current pagination looks strange as it is rendered being part of the
results and not just any other pagination in the backend.

Change it to be a normal pagination with having also the option to jump
to other pages.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 2026

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 10/13/23, 06:12

  1. core-ci voted on patch set 1 V -1 10/13/23, 06:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47733

  2. Oliver Hader updated the commit message in patch set 2 V -1 10/18/24, 14:10

  3. Garvin Hicking commented on patch set 2 06/20/25, 12:42

  4. Moritz Eckert uploaded patch set 3 08/07/25, 19:09

  5. core-ci voted on patch set 3 V +1 08/07/25, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82880

  6. Georg Ringer commented on patch set 3 08/07/25, 19:21

    This change is ready for review.
  7. Moritz Eckert updated the commit message in patch set 4 V +1 08/07/25, 19:24

  8. Sascha Nowak voted on patch set 4 CR +1 V +1 08/07/25, 19:34

  9. core-ci voted on patch set 4 V +1 08/07/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82883

  10. Oli Bartsch commented on patch set 4 CR -1 08/15/25, 08:51

    on it
  11. Oli Bartsch uploaded patch set 5 CR +1 V +1 08/15/25, 08:52

  12. Oli Bartsch commented on patch set 5 CR +1 V +1 08/15/25, 08:53

    Reply

    Done
  13. core-ci voted on patch set 5 V +1 08/15/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83442

  14. Sascha Nowak voted on patch set 5 CR +1 V +1 08/15/25, 11:53

  15. Oli Bartsch commented on patch set 5 V 0 CR -1 08/15/25, 12:51

    Sorry, but after reviewing the patch again, I’ll need to adjust my votes. I noticed a few issues in its current form: - Utility classes `mt-3` are added in a component that already has dedicated styling. - New classes are introduced but remain unused: `resource-tiles-pagination`, `resource-tiles-pagination-backward`, `resource-tiles-pagination-forward`. - The `PaginationTile` section becomes unused. I think it might be worth stepping back from this current approach and exploring something more future-proof — for example, a “load on scrolling” mechanism. That could simplify the styling and avoid unused elements while still achieving the intended goal.
  16. Georg Ringer voted on patch set 5 CR +1 V +1 08/16/25, 07:51

  17. Moritz Eckert uploaded patch set 6 CR +1 V +1 09/23/25, 15:35

  18. core-ci voted on patch set 6 V +1 09/23/25, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85399

  19. Moritz Eckert commented on patch set 6 09/23/25, 15:47

    Reply

    I’ve removed the utility class mt-3, the unused classes resource-tiles-pagination, resource-tiles-pagination-backward, resource-tiles-pagination-forward and the unused section PaginationTile you mentioned. In my opinion it makes sense to first focus on fixing the existing bug and ideally get that into version 13. A “load on scroll” approach could be added later as a feature of a further patch.
  20. Oli Bartsch commented on patch set 6 09/23/25, 17:35

    Reply Unresolved

    Alright thanks! I've two remarks on the current patchset: 1. Please let it look identical to list view by surrounding the labels with []. 2. The tiles jump when going up and you reach the first page (link disappears). We should place the pagination somehow above / below in a way that the place is already reserved so no jumping happens. In the list view this is circumvented due to the use of an already existing table row.
  21. Georg Ringer uploaded patch set 7 V +1 12/29/25, 18:18

  22. core-ci voted on patch set 7 V +1 12/29/25, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92790

  23. Simon Schaufelberger commented on patch set 7 01/01/26, 17:40

    Unresolved

    Can we use the same pagination like in the styleguide under the url: /typo3/module/styleguide/components?action=pagination ?
  24. Sascha Nowak wrote 02/03/26, 16:13

    Removed reviewer Sascha Nowak.
  25. Georg Ringer abandoned the change 02/04/26, 20:21