81423[BUGFIX] Improve pagination of tile view in filelist
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 2026
Show 1 earlier messages
-
Georg Ringer uploaded patch set 1 10/13/23, 06:12
-
core-ci voted on patch set 1 V -1 10/13/23, 06:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47733
-
Oliver Hader updated the commit message in patch set 2
V -110/18/24, 14:10 -
Garvin Hicking commented on patch set 2 06/20/25, 12:42
see: https://docs.google.com/document/d/1M8a8XC8tQ8n8t75H5SW2pODSjJRYd21sCuourUbaEAo/edit?tab=t.0 -
Moritz Eckert uploaded patch set 3 08/07/25, 19:09
-
core-ci voted on patch set 3 V +1 08/07/25, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82880
-
Georg Ringer commented on patch set 3 08/07/25, 19:21
This change is ready for review. -
Moritz Eckert updated the commit message in patch set 4
V +108/07/25, 19:24 -
Sascha Nowak voted on patch set 4 CR +1 V +1 08/07/25, 19:34
-
core-ci voted on patch set 4 V +1 08/07/25, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82883
-
Oli Bartsch commented on patch set 4 CR -1 08/15/25, 08:51
on it -
Oli Bartsch uploaded patch set 5
CR +1V +108/15/25, 08:52 -
Oli Bartsch commented on patch set 5 CR +1 V +1 08/15/25, 08:53
Reply
Done -
core-ci voted on patch set 5 V +1 08/15/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83442
-
Sascha Nowak voted on patch set 5 CR +1 V +1 08/15/25, 11:53
-
Oli Bartsch commented on patch set 5 V 0 CR -1 08/15/25, 12:51
Sorry, but after reviewing the patch again, I’ll need to adjust my votes. I noticed a few issues in its current form: - Utility classes `mt-3` are added in a component that already has dedicated styling. - New classes are introduced but remain unused: `resource-tiles-pagination`, `resource-tiles-pagination-backward`, `resource-tiles-pagination-forward`. - The `PaginationTile` section becomes unused. I think it might be worth stepping back from this current approach and exploring something more future-proof — for example, a “load on scrolling” mechanism. That could simplify the styling and avoid unused elements while still achieving the intended goal. -
Georg Ringer voted on patch set 5 CR +1 V +1 08/16/25, 07:51
-
Moritz Eckert uploaded patch set 6
CR +1V +109/23/25, 15:35 -
core-ci voted on patch set 6 V +1 09/23/25, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85399
-
Moritz Eckert commented on patch set 6 09/23/25, 15:47
Reply
I’ve removed the utility class mt-3, the unused classes resource-tiles-pagination, resource-tiles-pagination-backward, resource-tiles-pagination-forward and the unused section PaginationTile you mentioned. In my opinion it makes sense to first focus on fixing the existing bug and ideally get that into version 13. A “load on scroll” approach could be added later as a feature of a further patch. -
Oli Bartsch commented on patch set 6 09/23/25, 17:35
Reply Unresolved
Alright thanks! I've two remarks on the current patchset: 1. Please let it look identical to list view by surrounding the labels with []. 2. The tiles jump when going up and you reach the first page (link disappears). We should place the pagination somehow above / below in a way that the place is already reserved so no jumping happens. In the list view this is circumvented due to the use of an already existing table row. -
Georg Ringer uploaded patch set 7
V +112/29/25, 18:18 -
core-ci voted on patch set 7 V +1 12/29/25, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92790
-
Simon Schaufelberger commented on patch set 7 01/01/26, 17:40
Unresolved
Can we use the same pagination like in the styleguide under the url: /typo3/module/styleguide/components?action=pagination ? -
Sascha Nowak wrote 02/03/26, 16:13
Removed reviewer Sascha Nowak. -
Georg Ringer abandoned the change 02/04/26, 20:21