81428[TASK] Migrate ImageMagick $info array to dedicated object
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php2+84 −51
- typo3/sysext/core/Classes/Imaging/ImageProcessingResult.php12new+103 −0
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+13 −17
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+2 −2
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessingInstructionsTest.php2+2 −0
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+25 −22
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+24 −24
Review log 2438
Show 713 earlier messages
-
Benni Mack uploaded patch set 1 10/14/23, 18:15
-
core-ci voted on patch set 1 V -1 10/14/23, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47761
-
Benni Mack uploaded patch set 2
V -110/14/23, 18:31 -
core-ci voted on patch set 2 V +1 10/14/23, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47762
-
Oliver Klee commented on patch set 2 10/15/23, 08:39
ImageProcessingResult.php:38`int<0, max>` for bothImageProcessingResult.php:53`@return int<0, max>`ImageProcessingResult.php:58`@return int<0, max>`ImageProcessingResult.php:73`@return array{0: int<0, max>, 1: int<0, max>, 2: string, 3: string}`ImageProcessingInstructionsTest.php:287`@param int<0, max>` for both (which rightfully might avoid some PHPStan warnings) -
Benni Mack uploaded patch set 3
V +110/21/23, 19:23 -
core-ci voted on patch set 3 V -1 10/21/23, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48011
-
Benni Mack uploaded patch set 4 10/22/23, 09:08
Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE") -
Benni Mack uploaded patch set 5
V -110/22/23, 09:16 -
core-ci voted on patch set 4 V -1 10/22/23, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48023
-
core-ci voted on patch set 5 V -1 10/22/23, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48024
-
Benni Mack uploaded patch set 6
V -110/22/23, 10:07 -
core-ci voted on patch set 6 V -1 10/22/23, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48028
-
Benni Mack uploaded patch set 7
V -110/22/23, 16:21 -
core-ci voted on patch set 7 V +1 10/22/23, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48048
-
Benni Mack uploaded patch set 8
V +110/23/23, 09:54 -
core-ci voted on patch set 8 V +1 10/23/23, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48079
-
Benni Mack updated the commit message in patch set 9
V +110/24/23, 15:07 -
core-ci voted on patch set 9 V +1 10/24/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48131
-
Benni Mack uploaded patch set 10
V +112/15/23, 22:15 -
Benni Mack uploaded patch set 11 12/15/23, 22:17
-
core-ci voted on patch set 10 V +1 12/15/23, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50728
-
Benni Mack commented on patch set 11 12/15/23, 22:21
ImageProcessingInstructions.php:90ReplyDoneImageProcessingResult.php:38ReplyDoneImageProcessingResult.php:53ReplyDoneImageProcessingResult.php:58ReplyDoneImageProcessingResult.php:73ReplyDoneImageProcessingInstructionsTest.php:287ReplyDone -
core-ci voted on patch set 11 V +1 12/15/23, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50729
-
Oliver Klee voted on patch set 11 V +1 12/15/23, 23:43
-
Benni Mack rebased onto patch set 12
V +112/18/23, 10:50 -
core-ci voted on patch set 12 V +1 12/18/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50768
-
Oliver Klee voted on patch set 12 V +1 12/18/23, 11:51
-
Oliver Klee voted on patch set 12 CR +1 12/18/23, 14:30
-
Oli Bartsch commented on patch set 12 12/18/23, 16:11
GraphicalFunctions.php:289Why not using "web" as default since it's set for NULL anyways.ImageProcessingResult.php:27ItImageProcessingResult.php:99I suggest making this more clear by either checking for null or with an instanceof check. -
Stefan Bürk updated the commit message in patch set 13
CR +1V +112/19/23, 05:16 -
core-ci voted on patch set 13 V +1 12/19/23, 05:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50782
-
Oli Bartsch uploaded patch set 14
V +112/19/23, 08:36 -
Oli Bartsch commented on patch set 14 CR +1 V +1 12/19/23, 08:37
GraphicalFunctions.php:289ReplyDoneImageProcessingResult.php:27ReplyDoneImageProcessingResult.php:99ReplyDone -
core-ci voted on patch set 14 V +1 12/19/23, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50792
-
Oliver Klee voted on patch set 14 CR +1 V +1 12/19/23, 08:59
-
Oli Bartsch voted on patch set 14 CR +2 V +2 12/19/23, 09:07
-
Oli Bartsch merged patch set 15 12/19/23, 09:07
ImageProcessingInstructions.php:90