Review main Merged

81431[TASK] Avoid a pass-by-reference in DataHandler

Christian Kuhn CR +2 V +2 Easy +8 −14 updated 10/15/23, 13:41

Commit message

There is no point calling addDefaultPermittedLanguageIfNotSet()
with $incomingFieldArray as reference. It is more easy to see
the method can change $incomingFieldArray when it simply
returns the updated array instead.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Kuhn uploaded patch set 1 10/15/23, 12:08

  2. Christian Kuhn updated the commit message in patch set 2 10/15/23, 12:13

  3. core-ci voted on patch set 1 V +1 10/15/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47772

  4. core-ci voted on patch set 2 V +1 10/15/23, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47773

  5. Oliver Klee commented on patch set 2 10/15/23, 12:31

    DataHandler.php:8273

    This line seems to be redundant with the last line in the method.
  6. Christian Kuhn uploaded patch set 3 V +1 10/15/23, 12:35

  7. Christian Kuhn commented on patch set 2 10/15/23, 12:36

    DataHandler.php:8273 Reply

    Done
  8. Jasmina Ließmann voted on patch set 3 CR +1 10/15/23, 12:39

  9. core-ci voted on patch set 3 V +1 10/15/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47774

  10. Oliver Klee voted on patch set 3 V +1 CR +1 10/15/23, 13:20

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 10/15/23, 13:40

  12. Stefan Bürk merged patch set 4 10/15/23, 13:41