Review main Merged

81438[BUGFIX] Allow more TCA types for reaction fields

Georg Ringer CR +2 V +2 Easy +1 −1 updated 10/18/23, 09:52

Commit message

More TCA types must be allowed for field mapping of reactions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 10/16/23, 18:33

  2. Georg Ringer commented on patch set 1 10/16/23, 18:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/16/23, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47837

  4. Christian Kuhn commented on patch set 1 10/17/23, 07:51

    FieldMapElement.php:42

    i would rather tend to not add uuid here: this would allow creating multiple records with the same hard-coded uuid, which is pretty much exactly what uuid is not supposed to do ;) i'll edit the patch to skip uuid.
  5. Christian Kuhn commented on patch set 2 V +1 10/17/23, 07:51

    Published edit on patch set 1.
  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/17/23, 07:51

  7. core-ci voted on patch set 2 V +1 10/17/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47848

  8. Georg Ringer voted on patch set 2 V +1 CR +1 10/17/23, 08:29

  9. Benni Mack voted on patch set 2 V +1 CR +1 10/17/23, 11:39

  10. Stefan Bürk voted on patch set 2 V +1 CR +1 10/17/23, 16:01

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 10/18/23, 09:41

  12. Stefan Bürk merged patch set 3 10/18/23, 09:52