Review main Merged

81439[TASK] Consistently apply ImageMagick parameters when converting

Benni Mack CR +2 V +2 Normal +65 −80 updated 10/18/23, 16:22

Commit message

One of the main methods for processing logic when
working the ImageMagick in TYPO3 is "imageMagickConvert".

This method is rather cryptic when detecting the file extension,
the final command and additional parameters / instructions
and default commands for certain file types, so this code is brought in
line with better naming and more readability.

The quality setting for example is now properly
used for jpg/jpeg files, which wasn't always the case.

In addition, all non-public properties are now typed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1