81441[FEATURE] Add PSR-14 event to adjust CLI `cleanup:flexforms`
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 6
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102181-RemovedCLIOptionsUsingBintypo3Cleanupflexforms.rst+5 −1
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-102184-PSR-14EventForFlexformCleanupCommand.rstnew+151 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+15 −2
- typo3/sysext/lowlevel/Classes/Event/ModifyRecordAfterFlexFormCleanupCommandEvent.phpnew+93 −0
- typo3/sysext/lowlevel/Tests/Functional/EventListener/ModifyRecordAfterFlexFormCleanupCommandEventListenerTest.phpnew+148 −0
- typo3/sysext/lowlevel/Tests/Unit/Event/ModifyRecordAfterFlexFormCleanupCommandEventTest.phpnew+82 −0
Review log 1826
Show 1 earlier messages
-
Garvin Hicking uploaded patch set 1 10/17/23, 09:17
-
Garvin Hicking uploaded patch set 2 10/17/23, 09:18
-
Christian Kuhn rebased onto patch set 3 10/17/23, 14:26
-
core-ci voted on patch set 3 V -1 10/17/23, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47873
-
Garvin Hicking uploaded patch set 4
V -110/20/23, 11:46 -
core-ci voted on patch set 4 V -1 10/20/23, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47969
-
Chris Müller uploaded patch set 5
V -110/20/23, 18:51 -
Chris Müller commented on patch set 5 10/20/23, 18:53
-
core-ci voted on patch set 5 V -1 10/20/23, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47992
-
Garvin Hicking commented on patch set 5 10/20/23, 21:53
Feature-102184-PSR-14EventForFlexformCleanupCommand.rst:68ReplyThanks for your comment! Yes, this WIP is still very rough. I already removed the flexform dependency in the test, it will not be needed. xml2array seems to be sufficient. Still ironing this out :-) -
Garvin Hicking uploaded patch set 6
V -110/25/23, 14:18 -
core-ci voted on patch set 6 V -1 10/25/23, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48172
-
Stefan Bürk commented on patch set 6 10/26/23, 21:44
Feature-102184-PSR-14EventForFlexformCleanupCommand.rst:66Even in a example, please add the strict check true (3rd) argument for in_array() usages to emphasize that we intentionally do a strict type check here. And it's a good thing to have that in example codes which may be copy&pasted. I know - still WIP. But had a peek how the work is going ;) -
Benni Mack commented on patch set 6 08/06/24, 15:37
please rebase and let's continue with this one -
Garvin Hicking commented on patch set 6 08/06/24, 15:46
Reply
Yep, it's on my list to finish before feature freeze (not sure I find the time in the next 2 vacation weeks; if anyone else wants to take on it, I'm not blocking) -
Garvin Hicking uploaded patch set 7
V -108/07/24, 09:36Rebase restructure rework -
core-ci voted on patch set 7 V -1 08/07/24, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62992
-
Garvin Hicking uploaded patch set 8
V -108/08/24, 09:24Add examples and tests -
core-ci voted on patch set 8 V +1 08/08/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63035
-
Garvin Hicking uploaded patch set 9
V +108/08/24, 09:30Add accidentally removed comment again -
core-ci voted on patch set 9 V -1 08/08/24, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63036
-
core-ci voted on patch set 9 V +1 08/08/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63036
-
Garvin Hicking commented on patch set 9 08/08/24, 09:52
Patch ready for reviewFeature-102184-PSR-14EventForFlexformCleanupCommand.rst:66ReplyDoneFeature-102184-PSR-14EventForFlexformCleanupCommand.rst:68ReplyDone -
Guido Schmechel voted on patch set 9 CR +1 08/18/24, 12:08
-
Christian Kuhn commented on patch set 9 CR -1 08/21/24, 18:58
there are various issues with this: first, there is actually little reason to suppress updating db-integrity changes for certain things. second, the 'getCleanXml()' is an event that is like a 'poor man' upgrade wizard. third, the event could in general be substituted by a custom command. overall, anja, garvin and me came to the conclusion we should not apply this patch at all. -
Garvin Hicking abandoned the change 08/21/24, 18:58
See above. All good :)
Feature-102184-PSR-14EventForFlexformCleanupCommand.rst:68