Review main Merged

81443[TASK] Streamline ReferenceIndex->updateRefIndexTable()

Christian Kuhn CR +2 V +2 Hard +251 −317 updated 10/17/23, 14:17

Commit message

With ReferenceIndex->updateIndex() being pretty much
cleaned up and optimized, we start looking at the main
worker method updateRefIndexTable().

The patch refactors some details to make the method
more easy to follow. updateIndex() now hands over the
current record to suppress another DB call per row which
improves 'bin/typo3 referenceindex:update' performance.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1319

  1. Christian Kuhn uploaded patch set 1 10/17/23, 11:29

  2. Christian Kuhn uploaded patch set 2 10/17/23, 11:35

  3. core-ci voted on patch set 1 V -1 10/17/23, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47859

  4. core-ci voted on patch set 2 V -1 10/17/23, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47861

  5. Christian Kuhn uploaded patch set 3 V -1 10/17/23, 13:18

  6. Christian Kuhn uploaded patch set 4 10/17/23, 13:20

  7. core-ci voted on patch set 3 V +1 10/17/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47868

  8. core-ci voted on patch set 4 V +1 10/17/23, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47869

  9. Christian Kuhn updated the commit message in patch set 5 V +1 10/17/23, 13:32

  10. Christian Kuhn uploaded patch set 6 10/17/23, 13:34

  11. Christian Kuhn updated the commit message in patch set 7 10/17/23, 13:35

  12. Benni Mack voted on patch set 7 V +1 CR +1 10/17/23, 13:38

  13. core-ci voted on patch set 6 V +1 10/17/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47871

  14. core-ci voted on patch set 7 V +1 10/17/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47872

  15. Nikita Hovratov commented on patch set 7 10/17/23, 13:46

    pages-and-ttcontent-with-corrupt-image.xml:243

    should be tabs here. editorconfig is still wrong I guess..
  16. Christian Kuhn commented on patch set 7 10/17/23, 13:52

    pages-and-ttcontent-with-corrupt-image.xml:243 Reply

    i don't care. either have a runTests.sh processor for this foo and establish something that takes care of it, or ignore "tabs vs. ws" here, imho.
  17. Stefan Bürk voted on patch set 7 V +1 CR +1 10/17/23, 13:52

  18. Christian Kuhn commented on patch set 7 V +2 CR +2 10/17/23, 14:14

    will merge now. Nikita and me will have a call tomorrow to see what can be done on xml cgl stuff.
  19. Christian Kuhn merged patch set 8 10/17/23, 14:17