81443[TASK] Streamline ReferenceIndex->updateRefIndexTable()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+129 −195
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml2+27 −27
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+27 −27
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+27 −27
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-softrefs.xml+41 −41
Review log 1319
-
Christian Kuhn uploaded patch set 1 10/17/23, 11:29
-
Christian Kuhn uploaded patch set 2 10/17/23, 11:35
-
core-ci voted on patch set 1 V -1 10/17/23, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47859
-
core-ci voted on patch set 2 V -1 10/17/23, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47861
-
Christian Kuhn uploaded patch set 3
V -110/17/23, 13:18 -
Christian Kuhn uploaded patch set 4 10/17/23, 13:20
-
core-ci voted on patch set 3 V +1 10/17/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47868
-
core-ci voted on patch set 4 V +1 10/17/23, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47869
-
Christian Kuhn updated the commit message in patch set 5
V +110/17/23, 13:32 -
Christian Kuhn uploaded patch set 6 10/17/23, 13:34
-
Christian Kuhn updated the commit message in patch set 7 10/17/23, 13:35
-
Benni Mack voted on patch set 7 V +1 CR +1 10/17/23, 13:38
-
core-ci voted on patch set 6 V +1 10/17/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47871
-
core-ci voted on patch set 7 V +1 10/17/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47872
-
Nikita Hovratov commented on patch set 7 10/17/23, 13:46
-
Christian Kuhn commented on patch set 7 10/17/23, 13:52
pages-and-ttcontent-with-corrupt-image.xml:243Replyi don't care. either have a runTests.sh processor for this foo and establish something that takes care of it, or ignore "tabs vs. ws" here, imho. -
Stefan Bürk voted on patch set 7 V +1 CR +1 10/17/23, 13:52
-
Christian Kuhn commented on patch set 7 V +2 CR +2 10/17/23, 14:14
will merge now. Nikita and me will have a call tomorrow to see what can be done on xml cgl stuff. -
Christian Kuhn merged patch set 8 10/17/23, 14:17
pages-and-ttcontent-with-corrupt-image.xml:243